From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-126073-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 83993 invoked by alias); 15 Sep 2015 10:50:31 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 83976 invoked by uid 89); 15 Sep 2015 10:50:30 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout25.012.net.il
Received: from mtaout25.012.net.il (HELO mtaout25.012.net.il) (80.179.55.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Sep 2015 10:50:28 +0000
Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NUP00J00SIG3700@mtaout25.012.net.il> for gdb-patches@sourceware.org; Tue, 15 Sep 2015 13:47:10 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NUP00DBBSMLEQ50@mtaout25.012.net.il>; Tue, 15 Sep 2015 13:47:10 +0300 (IDT)
Date: Tue, 15 Sep 2015 10:50:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 9/9] gdb: Change how frames are selected for 'frame' and 'info frame'.
In-reply-to: <20150915104051.GH32100@embecosm.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83d1xk7y8m.fsf@gnu.org>
References: <cover.1441996064.git.andrew.burgess@embecosm.com> <cover.1441996064.git.andrew.burgess@embecosm.com> <2d36cf742ecb05db45a18f5025f42ad58d780fa8.1441996064.git.andrew.burgess@embecosm.com> <83r3m43dx3.fsf@gnu.org> <20150915104051.GH32100@embecosm.com>
X-IsSubscribed: yes
X-SW-Source: 2015-09/txt/msg00313.txt.bz2

> Date: Tue, 15 Sep 2015 11:40:51 +0100
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> 
> Revised version of this patch.  Changes are:
> 
>   - Longer entry in NEWS file to address Eli's feedback.
>   - Updated doc string for "frame", "select-frame", and "info frame"
>     commands within gdb.  I forgot to do this in the first version of
>     the patch.

Thanks.  The documentation parts are OK.  The doc strings look good
to me, with one minor gotcha:

> +Select a stack frame by the frames stack frame address:\n\
                               ^^^^^^
This "frames" should be deleted, I think.