From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102544 invoked by alias); 26 May 2017 14:35:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102452 invoked by uid 89); 26 May 2017 14:35:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2369 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 May 2017 14:35:22 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dEGKm-0000JR-AU for gdb-patches@sourceware.org; Fri, 26 May 2017 10:35:24 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dEGKm-0000JJ-6y; Fri, 26 May 2017 10:35:20 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1157 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dEGKk-0000di-S3; Fri, 26 May 2017 10:35:19 -0400 Date: Fri, 26 May 2017 14:35:00 -0000 Message-Id: <83d1avk7ob.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: brobecker@adacore.com, simon.marchi@polymtl.ca, gdb-patches@sourceware.org In-reply-to: <85877f9a-707d-dd19-f287-5fb1db3bc783@redhat.com> (message from Pedro Alves on Fri, 26 May 2017 15:10:01 +0100) Subject: Re: GDB 7.99.91 MinGW compilation error in cli-script.c Reply-to: Eli Zaretskii References: <83fug35v70.fsf@gnu.org> <83y3tt2ow0.fsf@gnu.org> <83vaox2j0w.fsf@gnu.org> <7017128a-7b51-5436-657b-58807d04eb02@redhat.com> <83vaouns1q.fsf@gnu.org> <837f18ohr2.fsf@gnu.org> <54594002-5d70-9ff8-c481-0cbfc8c68c7b@redhat.com> <834lwam7n4.fsf@gnu.org> <20170524193716.5arjibe4s5efvgj7@adacore.com> <15568468-0852-d786-8777-4adbd16825a0@redhat.com> <83tw48jc0f.fsf@gnu.org> <209349d7-a2b5-74ab-3b49-553d6e9ed97e@redhat.com> <83h907kbyg.fsf@gnu.org> <85877f9a-707d-dd19-f287-5fb1db3bc783@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00563.txt.bz2 > Cc: brobecker@adacore.com, simon.marchi@polymtl.ca, gdb-patches@sourceware.org > From: Pedro Alves > Date: Fri, 26 May 2017 15:10:01 +0100 > > > So the convention is to include the full qualifier of every method? > > Including the namespace of the class? Does that include the whole > > chain of namespaces up to the root? If not, where does one stop? > > I admit that I'm puzzled about you having an issue with > gdb::to_string, when your original entry said "(std::to_string)", > not "(to_string)". I did that because of the different namespaces involved in that particular change. But that was an exception: I normally don't look too hard at what Emacs's add-log commands produce in the parentheses, I just trust it to DTRT. Having to manually correct that in each case is a complication. > I think the convention is to provide enough qualifiers to > to make it convenient to search/see what function was changed. > For class methods, I think we should include the class name, > otherwise it can get ambiguous. I'm fine with not mentioning > the namespace when otherwise it's obvious or redundant. E.g., > if all of gdb was in namespace gdb [it's not], it'd probably not > make much sense to keep putting "gdb::" everywhere. But when > referring to a symbol outside gdb's namespace, I'd think it wise to > mention the namespace, so that it's clearer what the entry > is referring to. Well, I suggest to document these conventions somewhere, like the Wiki. I don't think they are self-evident, and standards.texi doesn't say anything about qualifying method names, it just tells to use the Emacs add-log commands and the related VC features. > I never managed to get used to using emacs commands to write the ChangeLog. > I write ChangeLog entries manually, directly in the git commit log, > while scrolling through the diff, as last "self review" event, and > then copy over to the ChangeLog file at push time. You will find some advice for a better workflow in the CONTRIBUTE file in the Emacs repository (http://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE). I've just asked the CC Mode maintainer to allow the add-log commands to not strip the class qualifiers. But namespace qualifiers will still have to be added by hand, I'm afraid, which is a bit of a nuisance, IMO.