From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106965 invoked by alias); 20 Jun 2017 15:19:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106917 invoked by uid 89); 20 Jun 2017 15:19:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RCVD_IN_BRBL_LASTEXT,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=kbd, acronym, documents X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 15:19:05 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dNKvi-0006kG-Bn for gdb-patches@sourceware.org; Tue, 20 Jun 2017 11:19:03 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dNKvR-0006XM-96; Tue, 20 Jun 2017 11:18:41 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2307 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dNKvQ-0001mc-Gz; Tue, 20 Jun 2017 11:18:40 -0400 Date: Tue, 20 Jun 2017 15:19:00 -0000 Message-Id: <83d19ywuuw.fsf@gnu.org> From: Eli Zaretskii To: Jan Kratochvil CC: gdb-patches@sourceware.org, vleschuk@accesssoftek.com In-reply-to: <149790574432.20186.16599093068806909362.stgit@host1.jankratochvil.net> (message from Jan Kratochvil on Mon, 19 Jun 2017 22:55:44 +0200) Subject: Re: [PATCH v3 2/5] DWARF-5: .debug_names index producer Reply-to: Eli Zaretskii References: <149790572259.20186.14601775821404892582.stgit@host1.jankratochvil.net> <149790574432.20186.16599093068806909362.stgit@host1.jankratochvil.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00576.txt.bz2 > From: Jan Kratochvil > Cc: Victor Leschuk > Date: Mon, 19 Jun 2017 22:55:44 +0200 > > @table @code > -@item save gdb-index @var{directory} > +@item save gdb-index [-dwarf-4] @var{directory} > @kindex save gdb-index > Create an index file for each symbol file currently known by > @value{GDBN}. Each file is named after its corresponding symbol file, > -with @samp{.gdb-index} appended, and is written into the given > -@var{directory}. > +with @samp{.debug_names} and @samp{.str} (or @samp{.gdb-index} > +from @code{-dwarf-4} option for older index consumers) appended, and is written > +into the given @var{directory}. The file-name extensions are better put in @file. More importantly, this text is now confusing: what do you mean by "with @samp{.debug_names} and @samp{.str}"? Do we produce one file or two? If only one, then what determines whether its extension will be .debug_names or .str? Once I understand this, I could suggest an alternative wording to clarify the issue. > This section documents the index section that is created by @code{save > -gdb-index} (@pxref{Index Files}). The index section is > +gdb-index -dwarf-4} (@pxref{Index Files}). Currently preferred section is The command should be in @kbd, not @code, as it's something the user types on the keyboard. > +@code{.debug_names} as produced by the default @code{save gdb-index} command. > +@code{.debug_names} section is documented in official @code{DWARF-5} DWARF-5 should not be in @code. Maybe in @acronym, or even no markup at all. > c = add_cmd ("gdb-index", class_files, save_gdb_index_command, > _("\ > Save a gdb-index file.\n\ > -Usage: save gdb-index DIRECTORY"), > +Usage: save gdb-index [-dwarf-4] DIRECTORY"), > &save_cmdlist); I think we should have a short explanation how the -dwarf-4 option changes the behavior. Thanks.