From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7IA8EuaBm2dyaB8AWB0awg (envelope-from ) for ; Thu, 30 Jan 2025 08:43:02 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Tw+L2zkR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 37FF91E105; Thu, 30 Jan 2025 08:43:02 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6431E1E08E for ; Thu, 30 Jan 2025 08:43:01 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EA8463858C56 for ; Thu, 30 Jan 2025 13:43:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EA8463858C56 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Tw+L2zkR Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 7085B3858D34 for ; Thu, 30 Jan 2025 13:42:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7085B3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7085B3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738244541; cv=none; b=rXkkw8p4U0WQHx8bb/6NJTgTjbAtlJ7SeVDrXGAALmvisJsgjTLlyB/aI30nQaCV1ChegNwwhrH7nOKiuYLBX7XH0zV9bxy0ZN0gtSfJAsEbXbrMJqIdKAK6+3rfai/u9P9rrpf+XCKHC9cs3jSIftFxuYSDIrTjtuyJ46dgX0M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738244541; c=relaxed/simple; bh=JQa4Km2YpxnjRMrSdrrSAnSKaosjbjhLm9eTPrI+UPw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=rxNoLXd14ho5MBTDpDSfZ8BlR7c/iwodnQv5IlpUg5wIoMudydrsU0qW/FV6Und4e/lkHNJFkQYNojKKQX4IbUTtJz7Ceqm0oJDr4NqYH4St2boNjp6xoxkk27pc7+yngRWrl7ptJiGHGKWMziyvjK3lhE1AD/nPk4VtOqAnoz4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7085B3858D34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738244541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EZmGhrr2v/UwXch7oeNzWnnXp7rZ9IUHP8muPyKbftM=; b=Tw+L2zkRmaXTcqMpoaqA3n+Ffvuk0j+zCZXReNlqJuvxDVcsgOYbofGswRyaKMxmnNCaUC 98/sDVBjxrWZkigYlBcnhxRzgs8S+54X3eRN8vR7lJHVG6RF/R5WA00ZPrRtUC4OzxMphb Q8j2bPXfdIIU7o6TuQhZycxCPIrZcJA= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-3iU8gZg0NgSRDo4YIBeVKg-1; Thu, 30 Jan 2025 08:42:20 -0500 X-MC-Unique: 3iU8gZg0NgSRDo4YIBeVKg-1 X-Mimecast-MFC-AGG-ID: 3iU8gZg0NgSRDo4YIBeVKg Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7bb849aa5fbso167151285a.0 for ; Thu, 30 Jan 2025 05:42:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738244539; x=1738849339; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EZmGhrr2v/UwXch7oeNzWnnXp7rZ9IUHP8muPyKbftM=; b=Xxk/xJZU8B+CYtxHgr8BJuidgDQVEGtvLCN8xaYTERlXiGhEDIxAeGFp+F1a20c1eB CqR7881MiZP0hatOx+dui/uXjuvuNmpV9f1cjpt36aVWbA9+Bm4NQF8b9JS9TFbHCqg8 WE966lebu4ZNct/sayK5vKwnL69SZ287w4+OXJJ1YF0CziBbMhsV2H5hF6PMR9df64AZ LnUQwvxVy4C0SjFRjTzDa0r02oJ44H9SGP98vQstiOLDZ0lpTNR6kcWjFhKVrq4FnyLw JqqhHRCseVwsT4u3QD54tAV2jXnVyPCk87swImQMtHkWtSX0/caa4zZhKlfdKjj7tgpe gP/A== X-Forwarded-Encrypted: i=1; AJvYcCXIDIV9tfJD1e2pxKYkbNGCB3ImlUnu5FOSKiiNzO+sRw8WQGOG3D5L6/PzkPij4AMZWxRWx2tlBjlk2w==@sourceware.org X-Gm-Message-State: AOJu0YyPSkLD5g1SK8Wjl2SKNsOhyi58zDWLaBbXuLIz5CrHF03PJ4j8 x1WJhFUQojsEuNDPwue4vJazyJLiT6mSbRs8uc9FslZatJaqzLG5Q3OcJ3BHSqWrq45t9K3iPKB SQL88808KglmaJ17DHs0lUMCsgLnEDE8KeJPpSm6FuDHRn3fDea09r8FRMfo= X-Gm-Gg: ASbGnct2tmBd1KXDv4TE1B4w+B2wpYn3bX+bJHFpcEM7hvMq8Y3c4A64KV7KEf3nvt8 paOVF46UD1GNErIxsLWCRZwFZ14Hbleouco/LQZBfpAu37t+tUJt+wEpFB9A+f/FRhfkWDagle/ iYs6JdNluxWkyWRnsYPMgSJ50JTuPezOIEeS6E0atEf2RMCjrbxMQyPdTZhD5SriL8mlj99SDfj oGacnY/0cwdBPaUA9cVWCVk4+p5u0h+HEElTqgURNMZjLtVAzdgV7Ps//Ux0JmLuHr5mmvB4oWO QKRgpVmV94J6aD90 X-Received: by 2002:a05:620a:2944:b0:7b6:d8aa:7ef9 with SMTP id af79cd13be357-7bffcd0eaa8mr1206357885a.32.1738244539518; Thu, 30 Jan 2025 05:42:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGsadDlm2dLMa8+ckfSPsnR+2pBZyMUcjzoQ4izrgwm5p/mLqpRemCtfbFKN3vmSk0XYfBvqA== X-Received: by 2002:a05:620a:2944:b0:7b6:d8aa:7ef9 with SMTP id af79cd13be357-7bffcd0eaa8mr1206354985a.32.1738244539259; Thu, 30 Jan 2025 05:42:19 -0800 (PST) Received: from ?IPV6:2804:14d:8084:9a69::1002? ([2804:14d:8084:9a69::1002]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c00a8d0313sm75280485a.38.2025.01.30.05.42.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 05:42:18 -0800 (PST) Message-ID: <83cfc395-c686-4a7f-9316-09aff205bbf5@redhat.com> Date: Thu, 30 Jan 2025 10:42:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/12] gdb, gdbarch: Introduce gdbarch method to get the shadow stack pointer. To: "Schimpe, Christina" , Luis Machado , "gdb-patches@sourceware.org" References: <20241220200501.324191-1-christina.schimpe@intel.com> <20241220200501.324191-12-christina.schimpe@intel.com> <1b66799d-486e-44ac-aab1-a51c13fa18d4@redhat.com> <73ba9c2a-2f2a-4876-83f6-c3436886a145@arm.com> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XMvt-dNEQuvfeaAAcT5pn13NvZliBZTli2ZXXc_hD9s_1738244539 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/30/25 9:34 AM, Schimpe, Christina wrote: >> -----Original Message----- >> From: Luis Machado >> Sent: Thursday, January 30, 2025 11:34 AM >> To: Guinevere Larsen ; Schimpe, Christina >> ; gdb-patches@sourceware.org >> Subject: Re: [PATCH 11/12] gdb, gdbarch: Introduce gdbarch method to get the >> shadow stack pointer. >> >> On 1/28/25 20:27, Guinevere Larsen wrote: >>> On 12/20/24 5:05 PM, Schimpe, Christina wrote: >>>> This patch is required by the following commit. >>>> --- >>> Maybe others disagree (in which case go with their suggestion), but my opinion >> is that, because you're only adding gdbarch functionality but no one uses it yet, >> there's basically no chance this commit could inadvertently break something, so it >> is fine to merge with the next one where you make use of the feature. >>> If these are split, I would like to have some explanation as to why it is required, >> but I imagine the explanation finds a better home in the next commit anyway, >> which is another reason why I'd join both commits. >> As a counterpoint, I suppose it is fine to do it this way for simplicity of reviewing, >> as it is broken up into smaller bits. Things will potentially be pushed as part of a >> series anyway. > Thanks for the feedback! > > In my opinion, splitting the commits simplifies the review, especially if the commits are bigger. > Also I thought it's good to keep target independent code separate. > > For the commit " gdb, gdbarch: Enable inferior calls for shadow stack support.", for instance, > I do not have 2 commits for the gdbarch function and it's usage, as in this case the gdbarch > function is called in target independent code only. I only have the implementation in a separate > commit "gdb: Implement amd64 linux shadow stack support for inferior calls.". > > But I understand Guinevere's suggestion here, especially because the commit that uses > gdbarch_get_shadow_stack_pointer is only called in a patch which isn't really too big to review. > > So I have mixed feelings about that and would be happy about a guideline. Yeah having had the time to read patch 12, I do think they'd go best together, but I don't know if there is any unified guidance on this. Whatever you decide is fine, though, I don't have too strong an opinion on this. -- Cheers, Guinevere Larsen She/Her/Hers