Re: [RFC][patch] Allow to disassemble line.

Tom Tromey
2009-10-19T17:47:47Z

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Paul> - ui_out_field_core_addr (uiout, "address", gdbarch, pc);
Paul> + ui_out_field_core_addr (uiout, "pc_addr", gdbarch, pc);

Changing a field name breaks MI clients.
So, I don't think this part is ok.

Paul> Index: ui-out.c
[...]
Paul> + if (strcmp (fldname, "pc_addr") == 0)
Paul> + ui_out_text (uiout, pc_prefix (address));

I think magic field names and extra behavior in low-level ui-out
functions is pretty ugly and also breaks an abstraction barrier.

Why not directly call ui_out_text in dump_insns?

Tom