From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13054 invoked by alias); 10 Apr 2010 07:10:29 -0000 Received: (qmail 13034 invoked by uid 22791); 10 Apr 2010 07:10:26 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Apr 2010 07:10:21 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0L0N00G00FMYN200@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Sat, 10 Apr 2010 10:09:57 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.124.92.42]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L0N00E7TFWK5GB0@a-mtaout21.012.net.il>; Sat, 10 Apr 2010 10:09:57 +0300 (IDT) Date: Sat, 10 Apr 2010 07:10:00 -0000 From: Eli Zaretskii Subject: Re: [RFC] Add login to remote protocol In-reply-to: <4BBFA9E1.1020609@codesourcery.com> To: Stan Shebs Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83bpdrzsu0.fsf@gnu.org> References: <4BBFA9E1.1020609@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00295.txt.bz2 > Date: Fri, 09 Apr 2010 15:27:45 -0700 > From: Stan Shebs > > + @item set remote username @var{username} > + @itemx show remote username > + Set the username to be sent to targets that require a login. The > + username is an arbitary string. > + > + @item set remote password @var{password} > + @itemx show remote password > + Set the password to be sent to targets that require a login. The > + password is an arbitary string. At present it is stored as cleartext. > + Two comments: . This needs @cindex entries for "remote username" and "remote password". . Wouldn't it be better to have just one command for both? A related question: once a non-empty password was specified, how to reset it back to empty? > + If the target requires a login (@samp{MustAuth} feature), > + then if this packet is not supplied soon after connection, then the > + target may choose to return errors to all subsequent packets and/or > + disconnect. Too many "then"s. I would simply remove the second one. > + @value{GDBN} must send an authorization packet @samp{qAuth} and the > + username/password pair must be accepted, otherwise the target will > + return an error and refuse to continue with the session. ^^^^ Probably "may" instead of "will" is more appropriate, since we don't actually know what the target does without the credentials. > + remote_username = xstrdup (""); > + add_setshow_string_noescape_cmd ("username", class_files, > + &remote_username, _("\ > + Set the remote username"), _("\ > + Show the remote username"), NULL, NULL, NULL, > + &remote_set_cmdlist, &remote_show_cmdlist); > + > + remote_password = xstrdup (""); > + add_setshow_string_noescape_cmd ("password", class_files, > + &remote_password, _("\ > + Set the remote password"), _("\ > + Show the remote password"), NULL, NULL, NULL, > + &remote_set_cmdlist, &remote_show_cmdlist); > + Please consider adding some explanatory text to the doc strings. Also, we will need a NEWS entry for this new feature.