From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28283 invoked by alias); 17 Feb 2012 11:37:48 -0000 Received: (qmail 28275 invoked by uid 22791); 17 Feb 2012 11:37:47 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Feb 2012 11:37:30 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LZJ00400C84CF00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Fri, 17 Feb 2012 13:37:28 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.150.51]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LZJ0043MCABA650@a-mtaout23.012.net.il>; Fri, 17 Feb 2012 13:37:26 +0200 (IST) Date: Fri, 17 Feb 2012 11:38:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 4/9] agent doc In-reply-to: <1329447300-18841-5-git-send-email-yao@codesourcery.com> To: Yao Qi Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83booxwv0m.fsf@gnu.org> References: <1329447300-18841-1-git-send-email-yao@codesourcery.com> <1329447300-18841-5-git-send-email-yao@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00363.txt.bz2 > From: Yao Qi > Date: Fri, 17 Feb 2012 10:54:55 +0800 > > Documentation bits. Leave original contents of node "Agent Expressions" there, with > some minor updates. A new node "Agent" is added. Thanks. > +Agent expression will be used in many cases, such as the expressions used in tracepoints > +for data collection, and expressions used in breakpoint condition evaluation. The Please always format the Texinfo sources with lines that don't exceed 80 characters, preferably even 72. > +expressions may also denote registers and objects in memory---structures or arrays, for > +example---whose values @value{GDBN} should record. Originally, agent expressions are used > +in @dfn{agent} (@pxref{Agent}), so they are called @dfn{Agent Expression}. I would leave only the latter @dfn, there seems to be no need for the former one, as you don't describe the agent in this section. > Gradually, > +they are used more widely, such as in remote stub. I don't understand what you wanted to say in this sentence. Does it really add anything important? > +The agent can interpret and execute @dfn{Agent Expressions} > +(@pxref{Agent Expressions}) during performing debugging operations. The Again, this @dfn is not appropriate here, because this section does not explain this term. > +@menu > +* Control Agent:: Turn agent on and off > +@end menu > +@node Control Agent > +@section Turn Agent On And Off > + > +You can control whether the agent is used as an aid for debugging > +with the following commands: > + > +@table @code > +@item set agent on @kindex is missing here. All commands should be indexed. > +Causes the agent to perform some operations on behalf of the > +debugger. Just which operations requested by the user will be done > +by the agent depends on the agent's capabilities. For example, if > +you request to evaluate breakpoint conditions in the agent, and the > +agent has such capability as well, then breakpoint conditions will be > +evaluated in the agent. > + > +@item set agent off > +Disables execution of debugging operations by the agent. All of the > +operations will be performed by @value{GDBN}. > +@end table Don't we also have "show agent"? Anyway, full section for just 2 commands seems like a waste of a section. Why not make it part of its parent chapter.