From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26807 invoked by alias); 3 May 2019 08:04:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26793 invoked by uid 89); 3 May 2019 08:04:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=U*palves, sk:palves, sk:palves@, palvesredhatcom X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 May 2019 08:04:21 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMTB4-00036R-40; Fri, 03 May 2019 04:04:19 -0400 Received: from [176.228.60.248] (port=3923 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hMTB3-0002DY-CJ; Fri, 03 May 2019 04:04:17 -0400 Date: Fri, 03 May 2019 08:04:00 -0000 Message-Id: <83bm0knevl.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves CC: gdb-patches@sourceware.org In-reply-to: (message from Pedro Alves on Tue, 30 Apr 2019 17:31:22 +0100) Subject: Re: Fix compilation using mingw.org's MinGW References: <835zrbe36c.fsf@gnu.org> <250801eb-14f6-5a35-0556-cf5797dd8a7b@redhat.com> <83y347cfbu.fsf@gnu.org> <556cefd7-47ce-54ab-a228-2c727aab4179@redhat.com> <83d0lick7o.fsf@gnu.org> <93ccb0fa-8a05-60ff-d1a8-85d5663b8d16@redhat.com> <831s1murm2.fsf@gnu.org> <83k1fbseiw.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00065.txt.bz2 > Cc: gdb-patches@sourceware.org > From: Pedro Alves > Date: Tue, 30 Apr 2019 17:31:22 +0100 > > On 4/30/19 4:23 PM, Eli Zaretskii wrote: > >> Cc: gdb-patches@sourceware.org > >> From: Pedro Alves > >> Date: Tue, 30 Apr 2019 14:10:53 +0100 > >> > >>> - The override in _WIN32_WINNT is no longer necessary. It could > >>> be removed at the same time. > >> > >> I meant the _WIN32_WINNT override in common/netstuff.c. > >> > >> I see now that there are more of those in other files too. > > > > I will review them for the changeset on master, but I don't think we > > should change them on the 8.3 branch. OK? > > Yes, my comments were for master, since changing removing the overrides > in the other files only makes sense with the _WIN32_WINNT definition > in common-defs.h. OK, done. I think I removed all the overrides that were there. Thanks.