From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8H4DKCRK8mJuqSMAWB0awg (envelope-from ) for ; Tue, 09 Aug 2022 07:51:00 -0400 Received: by simark.ca (Postfix, from userid 112) id 9A8D81E5EA; Tue, 9 Aug 2022 07:51:00 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=kZmYbqJ3; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4FB2A1E222 for ; Tue, 9 Aug 2022 07:51:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7C1243856DC2 for ; Tue, 9 Aug 2022 11:50:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C1243856DC2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1660045859; bh=2Z/gF6bhNBFNmEMrLPHX/YH93aOMt6nrV0mkgAmscCY=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=kZmYbqJ3b16aMZCBCtXe9LJ/EXKHicZ4/NNXiMJ4wJ0uM2uBGhvJLjAYU/8Fi7e4m sC416XVv5psxneim9bRpbMthWiZ0+4/8gFChS2ZxDvW2XlVaBt4mfjNmtC1n1ielSX zEZEkW+5bchiEzdm9Wu3PRhWU8A0y+BLikDcVXkU= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 95DF53857349 for ; Tue, 9 Aug 2022 11:50:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 95DF53857349 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLNks-0007zP-4r; Tue, 09 Aug 2022 07:50:38 -0400 Received: from [87.69.77.57] (port=3807 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLNkh-0007np-Do; Tue, 09 Aug 2022 07:50:27 -0400 Date: Tue, 09 Aug 2022 14:50:16 +0300 Message-Id: <83bkstvdon.fsf@gnu.org> To: Philippe Waroquiers In-Reply-To: <20220808194018.3781686-1-philippe.waroquiers@skynet.be> (message from Philippe Waroquiers via Gdb-patches on Mon, 8 Aug 2022 21:40:18 +0200) Subject: Re: [RFAv2] Allow to document user-defined aliases. References: <20220808194018.3781686-1-philippe.waroquiers@skynet.be> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Date: Mon, 8 Aug 2022 21:40:18 +0200 > From: Philippe Waroquiers via Gdb-patches > > gdb/NEWS | 10 ++++++ > gdb/cli/cli-decode.c | 59 ++++++++++++++++++++++++--------- > gdb/cli/cli-script.c | 41 ++++++++++++++--------- > gdb/doc/gdb.texinfo | 26 ++++++++++++++- > gdb/testsuite/gdb.base/help.exp | 44 ++++++++++++++++++++++-- > 5 files changed, 146 insertions(+), 34 deletions(-) Thanks. > diff --git a/gdb/NEWS b/gdb/NEWS > index 8c837df76e5..1b74e0fc1bd 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -93,6 +93,16 @@ show style disassembler symbol > > * Changed commands > > +document user-defined > + It is now possible to document user-defined aliases. > + When a user-defined alias is documented, the help and apropos commands > + use the provided documentation instead of the documentation of the > + aliased command. > + Documenting a user-defined alias is particularly useful when the alias > + is a set of nested 'with' commands to avoid showing the help of > + the with command for an alias that will in fact launch the > + last command given in the nested commands. > + This part is OK. > +A user-defined alias can optionally be documented using the @code{document} command > +(@pxref{Define, document}). > +@value{GDBN} then considers this alias as different of the aliased > +command: "different from the aliased command", not "different of". > this alias is not listed in the aliased command help output and asking ^ A comma missing there. > +help for this alias will show the user provided alias documentation > +instead of "will show the documentation provided for the alias instead of..." The documentation parts are OK with these nits fixed.