From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GXs+IPS2BWjBsD0AWB0awg (envelope-from ) for ; Sun, 20 Apr 2025 23:09:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1745204980; bh=UW7AzWBYanxl4nHheOGGjdmXVHImp1mELp9o5j9Z0bE=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iGwz1ykNvPNUA6ClCUEGIi/KXoFLXLqeH/w1OYbf5mSQR+QSi7Iws0XOrkoSFQNX7 SXm7IKXTGerxBLbBcupKxUMQSFEyanjIb7JrmLqr4h7clKf5WE/MZW2PmUvD628gAX e2WIFpucB1+q/3yr85IJw9JjWFYmFRGaCD9QbCbY= Received: by simark.ca (Postfix, from userid 112) id 734D51E0C3; Sun, 20 Apr 2025 23:09:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=DyQGX/72; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=RxxRvEcq; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E4CCD1E0C0 for ; Sun, 20 Apr 2025 23:09:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 82F4D3858C2D for ; Mon, 21 Apr 2025 03:09:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 82F4D3858C2D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=DyQGX/72; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=RxxRvEcq Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id F106A3858D37 for ; Mon, 21 Apr 2025 03:09:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F106A3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F106A3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745204948; cv=none; b=O+B838y4IKmihDcHF4BUhFezuetAce5vU5tjsxNVdusf4MV0uN7LF2ReAHSqIoiBnp37kt6U2eb+B08SHiOzu0CjdOJC7RdRHmamtA4ZWDDSvzeKc2xRt4z0IrZYRWhvKmn+BJpa4c/mwg3bTk1hnB9YWeZhx3tSa3IPCugBzLw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745204948; c=relaxed/simple; bh=UW7AzWBYanxl4nHheOGGjdmXVHImp1mELp9o5j9Z0bE=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=GQaXyzn3CRqNmveg5iKA42+IGSfRvJMgmF54O6OB6YIEPiLu3FVI6xxwf2CGe1hDkMJH14c6u0GRSn2VT08LSZdjlswiptMTL9itYRWYxZIk7dYCoiqt9gCfB1BQyiGMqyBTW6M942NwSkpRxX6B+RSp2yvzn4FbRKu/7Vz9Il8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F106A3858D37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1745204947; bh=UW7AzWBYanxl4nHheOGGjdmXVHImp1mELp9o5j9Z0bE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=DyQGX/72uqx7zGaePw27th9HzuD0uv4Rm4kcaH2a5B2xhgMv5VSsNaBb/oT512OQT rr/P4US2xUwP7whalgA3YcBUzugQjgR88y30wZN/28mm+hfdwkFStCU+Zqrt+kYJMY H6tKo0F7a/Pwn/8mNvjoWmZMliut3pSQkpupvdBg= Received: by simark.ca (Postfix, from userid 112) id 7DCE21E0C3; Sun, 20 Apr 2025 23:09:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1745204946; bh=UW7AzWBYanxl4nHheOGGjdmXVHImp1mELp9o5j9Z0bE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=RxxRvEcq1xFY6NtBF7iwNprpvjf/qfnKxsZUfgsq/gHlHWFhdtdGmEgxDmyQ0nO8M 09u8bGGnhUyQbAIx04PhTN88/ZKNH20OOPUabYmdZZDTNiIwzZ5wb2PDbEoXo3Kn5W 0I8/8h2VWhxoCflQ5szApgeIxtCJgxwszFbTQUms= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B69181E0C0; Sun, 20 Apr 2025 23:09:06 -0400 (EDT) Message-ID: <83b9f38b-22f0-476d-b2dc-0501b41e2738@simark.ca> Date: Sun, 20 Apr 2025 23:09:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/28] Remove dwarf2_per_cu_data::mark To: Tom Tromey , gdb-patches@sourceware.org References: <20250402-search-in-psyms-v2-0-ea91704487cb@tromey.com> <20250402-search-in-psyms-v2-9-ea91704487cb@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20250402-search-in-psyms-v2-9-ea91704487cb@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-04-02 19:45, Tom Tromey wrote: > This removes dwarf2_per_cu_data::mark, replacing it with a > locally-allocated boolean vector. It also inverts the sense of the > flag -- now, the flag is true when a CU should be skipped, and false > when the CU should be further examined. Also, the validity of the > flag is no longer dependent on 'file_matcher != NULL'. > > This patch makes the subsequent patch to searching a bit simpler, so > I've separated it out. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=16994 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=16998 > --- > gdb/dwarf2/read-gdb-index.c | 14 +++++----- > gdb/dwarf2/read.c | 64 ++++++++++++++++++++++++++------------------- > gdb/dwarf2/read.h | 35 +++++++++++++++++++++---- > 3 files changed, 75 insertions(+), 38 deletions(-) > > diff --git a/gdb/dwarf2/read-gdb-index.c b/gdb/dwarf2/read-gdb-index.c > index eeaa38a502c09a0acdd1b60a1c0b8403843aa9fe..7bcf50d347609f0b27068228cd78633dd57e1556 100644 > --- a/gdb/dwarf2/read-gdb-index.c > +++ b/gdb/dwarf2/read-gdb-index.c > @@ -1030,6 +1030,7 @@ dwarf2_gdb_index::dump (struct objfile *objfile) > > static bool > dw2_expand_marked_cus (dwarf2_per_objfile *per_objfile, offset_type idx, > + auto_bool_vector &marked, > expand_symtabs_file_matcher file_matcher, > expand_symtabs_expansion_listener expansion_notify, > block_search_flags search_flags, Can you choose a different name for these "marked" parameters? That name doesn't convey what a mark means. Perhaps "visited_cus", or something like that. Also, does the "marked" in "dw2_expand_marked_cus" have the same meaning as the "marked" that changed meaning in this patch? If so, does this function need to be renamed (does it do the opposite of the what its name imply now)? Simon