From: Eli Zaretskii <eliz@gnu.org>
To: gdb-patches@sourceware.org
Subject: [RFA] Fix documentation of snprintf and vsnprintf
Date: Sat, 23 May 2009 13:48:00 -0000 [thread overview]
Message-ID: <83ab54szfc.fsf@gnu.org> (raw)
The current documentation of these two functions is misleading, and can
easily cause off-by-one bugs, if one follows it to the letter and
doesn't double-check with what the source actually does.
I tried to be more accurate in the patch below.
OK?
2009-05-23 Eli Zaretskii <eliz@gnu.org>
* snprintf.c: Doc fix.
* vsnprintf.c: Doc fix.
--- libiberty/snprintf.c~0 2005-05-10 21:33:34.000000000 +0300
+++ libiberty/snprintf.c 2009-05-23 16:34:39.265625000 +0300
@@ -27,13 +27,14 @@
@deftypefn Supplemental int snprintf (char *@var{buf}, size_t @var{n}, const char *@var{format}, ...)
-This function is similar to sprintf, but it will print at most @var{n}
-characters. On error the return value is -1, otherwise it returns the
-number of characters that would have been printed had @var{n} been
-sufficiently large, regardless of the actual value of @var{n}. Note
-some pre-C99 system libraries do not implement this correctly so users
-cannot generally rely on the return value if the system version of
-this function is used.
+This function is similar to @code{sprintf}, but it will write at most
+var{n} bytes (including the terminating null byte) to @var{buf}.
+On error the return value is -1, otherwise it returns the number of
+bytes, not including the terminating null byte, that would have been
+written had @var{n} been sufficiently large, regardless of the actual
+value of @var{n}. Note some pre-C99 system libraries do not implement
+this correctly so users cannot generally rely on the return value if
+the system version of this function is used.
@end deftypefn
--- libiberty/vsnprintf.c~0 2005-05-10 21:33:34.000000000 +0300
+++ libiberty/vsnprintf.c 2009-05-23 16:36:07.265625000 +0300
@@ -27,13 +27,14 @@
@deftypefn Supplemental int vsnprintf (char *@var{buf}, size_t @var{n}, const char *@var{format}, va_list @var{ap})
-This function is similar to vsprintf, but it will print at most
-@var{n} characters. On error the return value is -1, otherwise it
-returns the number of characters that would have been printed had
-@var{n} been sufficiently large, regardless of the actual value of
-@var{n}. Note some pre-C99 system libraries do not implement this
-correctly so users cannot generally rely on the return value if the
-system version of this function is used.
+This function is similar to @code{vsprintf}, but it will write at most
+@var{n} bytes (including the terminating null byte) to @var{buf}.
+On error the return value is -1, otherwise it returns the number of
+bytes, not including the terminating null byte, that would have been
+written had @var{n} been sufficiently large, regardless of the actual
+value of @var{n}. Note some pre-C99 system libraries do not implement
+this correctly so users cannot generally rely on the return value if
+the system version of this function is used.
@end deftypefn
next reply other threads:[~2009-05-23 13:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-23 13:48 Eli Zaretskii [this message]
2009-05-23 13:55 ` Pedro Alves
2009-05-23 17:02 ` Eli Zaretskii
2009-05-29 11:43 ` Eli Zaretskii
2009-05-29 20:22 ` DJ Delorie
2009-05-29 20:28 ` Dave Korn
2009-05-29 20:34 ` DJ Delorie
2009-05-29 20:39 ` Dave Korn
2009-05-29 20:59 ` Eli Zaretskii
2009-05-29 20:42 ` Eli Zaretskii
2009-05-29 20:45 ` DJ Delorie
2009-05-29 21:44 ` Eli Zaretskii
2009-05-30 5:18 ` DJ Delorie
[not found] <83d4a0szry.fsf@gnu.org>
[not found] ` <4A180840.3040004@gmail.com>
2009-05-23 17:13 ` Eli Zaretskii
2009-05-23 20:09 ` Dave Korn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ab54szfc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox