From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72417-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29068 invoked by alias); 22 Apr 2010 03:19:22 -0000
Received: (qmail 29051 invoked by uid 22791); 22 Apr 2010 03:19:19 -0000
X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Apr 2010 03:19:14 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L1900G00D512P00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Thu, 22 Apr 2010 06:18:46 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.228.129.222]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L1900DA2D79GHA0@a-mtaout22.012.net.il>; Thu, 22 Apr 2010 06:18:46 +0300 (IDT)
Date: Thu, 22 Apr 2010 03:19:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] doc-python: Pretty Printing split user / developer
In-reply-to: <20100421205046.GA25787@host0.dyn.jankratochvil.net>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83aasw41ka.fsf@gnu.org>
References: <20100421205046.GA25787@host0.dyn.jankratochvil.net>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00736.txt.bz2

> Date: Wed, 21 Apr 2010 22:50:46 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> which I try to address by the attachment.  Is it OK this way?

Thanks.

> +@smallexample
> +(@value{GDBP}) print s
> +$1 = @{
> +  static npos = 4294967295, 
> +  _M_dataplus = @{
> +    <std::allocator<char>> = @{
> +      <__gnu_cxx::new_allocator<char>> = @{<No data fields>@}, <No data fields>@}, 
> +    members of std::basic_string<char, std::char_traits<char>, std::allocator<char> >::_Alloc_hider: 
> +    _M_p = 0x804a014 "abcd"
> +  @}
> +@}
> +@end smallexample

The long lines here need to be wrapped, to become shorter than 72
characters.

>  * Auto-loading::                Automatically loading Python code.
>  * Values From Inferior::
>  * Types In Python::		Python representation of types.
> -* Pretty Printing::		Pretty-printing values.
> +* Pretty Printing API::		Pretty-printing values.
>  * Selecting Pretty-Printers::   How GDB chooses a pretty-printer.
>  * Commands In Python::          Implementing new commands in Python.
>  * Functions In Python::         Writing new convenience functions.

This menu uses TAB characters.  Please convert all of them to spaces
("M-x untabify" in Emacs).  Using TABs in a Texinfo file is a no-no,
because it causes line misalignment in the Info output.

> +@value{GDBN} provides a mechanism to allow pretty-printing of values using
> +Python code.  The pretty-printer API allows application-specific code to
> +greatly simplify the display of complex objects.

This repeats what you just said in the "Pretty Printing" section.  I
don't think we need to repeat that.

Okay with these changes.