From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24843 invoked by alias); 22 Oct 2010 21:31:14 -0000 Received: (qmail 24835 invoked by uid 22791); 22 Oct 2010 21:31:13 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Oct 2010 21:31:08 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LAP00A00NOBJK00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 22 Oct 2010 23:31:06 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.116.216]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LAP00ABWNRS0S70@a-mtaout22.012.net.il>; Fri, 22 Oct 2010 23:31:06 +0200 (IST) Date: Fri, 22 Oct 2010 21:31:00 -0000 From: Eli Zaretskii Subject: Re: [patch] Add visible flag to breakpoints. In-reply-to: To: pmuldoon@redhat.com Cc: tromey@redhat.com, pedro@codesourcery.com, gdb-patches@sourceware.org, dan@codesourcery.com Reply-to: Eli Zaretskii Message-id: <83aam59aot.fsf@gnu.org> References: <201010081435.15174.pedro@codesourcery.com> <201010162003.41609.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00355.txt.bz2 > From: Phil Muldoon > Cc: Pedro Alves , gdb-patches@sourceware.org, dan@codesourcery.com > Date: Fri, 22 Oct 2010 22:05:30 +0100 > > I decided to add internal watchpoint support. I've also added the other > changes requested. > > OK? Thanks. > -/* Set a breakpoint. This function is shared between CLI and MI > +/* Set a breakpoint. This function is shared between CLI and MI Why did you need to remove one of the two spaces between these sentences? > functions for setting a breakpoint. This function has two major > modes of operations, selected by the PARSE_CONDITION_AND_THREAD > parameter. If non-zero, the function will parse arg, extracting > breakpoint location, address and thread. Otherwise, ARG is just the > location of breakpoint, with condition and thread specified by the > - COND_STRING and THREAD parameters. Returns true if any breakpoint > - was created; false otherwise. */ > - > + COND_STRING and THREAD parameters. If INTERNAL is non-zero, the > + breakpoint number will be allocated from the internal breakpoint > + count. Returns true if any breakpoint was created; false ^^^ And here you have 3 instead of 2. > +@code{maint info breakpoints} command). The optional @var{wp_class} > argument defines the class of watchpoint to create, if @var{type} is > defined as @code{BP_WATCHPOINT}. "if @var{type} is @code{BP_WATCHPOINT}" is simpler and more clear, IMO. > +@defivar Breakpoint visible > +This attribute holds the breakpoint's visibility flag---the identifier used to > +determine whether the breakpoint is visible to the user when set, or > +when the @samp{info breakpoints} command is run. There's no need to go through identifiers. How about this rewording? This attribute tells whether the breakpoint is visible to the user when set, or when the @samp{info breakpoints} command is run. Thanks.