From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-146785-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8964 invoked by alias); 24 Apr 2018 16:43:19 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 8948 invoked by uid 89); 24 Apr 2018 16:43:18 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Apr 2018 16:43:18 +0000
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 93163722C7;	Tue, 24 Apr 2018 16:43:16 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 1ED0E215CDC8;	Tue, 24 Apr 2018 16:43:15 +0000 (UTC)
Subject: Re: [RFA 3/8] Make print_command_trace varargs
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20180419191539.661-1-tom@tromey.com> <20180419191539.661-4-tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <83aaf321-9721-ae30-49f8-8f8b66b8e9f9@redhat.com>
Date: Tue, 24 Apr 2018 16:43:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180419191539.661-4-tom@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-04/txt/msg00477.txt.bz2

On 04/19/2018 08:15 PM, Tom Tromey wrote:
> I noticed some code in execute_control_command_1 that could be
> simplified by making print_command_trace a printf-like function.  This
> patch makes this change.
> 
> 2018-04-19  Tom Tromey  <tom@tromey.com>
> 
> 	* top.c (execute_command): Update.
> 	* cli/cli-script.h (print_command_lines): Now varargs.
> 	* cli/cli-script.c (print_command_lines): Now varargs.
> 	(execute_control_command_1) <case while_control, case if_control>:
> 	Update.

Looks fine to me.

Thanks,
Pedro Alves