From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25921 invoked by alias); 25 Nov 2011 18:20:12 -0000 Received: (qmail 25913 invoked by uid 22791); 25 Nov 2011 18:20:11 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Nov 2011 18:19:56 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LV800E00ASB9K00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 25 Nov 2011 20:19:52 +0200 (IST) Received: from HOME-C4E4A596F7 ([84.228.50.247]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LV800B24AX3VW01@a-mtaout20.012.net.il>; Fri, 25 Nov 2011 20:19:52 +0200 (IST) Date: Fri, 25 Nov 2011 18:20:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 18/348] Fix -Wsahdow warnings In-reply-to: <201111251626.pAPGQ3rN016558@glazunov.sibelius.xs4all.nl> To: Mark Kettenis Cc: brobecker@adacore.com, andrew.smirnov@gmail.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83aa7k83p0.fsf@gnu.org> References: <201111231640.pANGefc4031803@d06av02.portsmouth.uk.ibm.com> <201111231820.40486.pedro@codesourcery.com> <201111232023.pANKNcLf022983@glazunov.sibelius.xs4all.nl> <20111124220057.GU13809@adacore.com> <83hb1s8l5c.fsf@gnu.org> <201111251511.pAPFBBkP007292@glazunov.sibelius.xs4all.nl> <83ehww8b1t.fsf@gnu.org> <201111251626.pAPGQ3rN016558@glazunov.sibelius.xs4all.nl> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00705.txt.bz2 > Date: Fri, 25 Nov 2011 17:26:04 +0100 (CET) > From: Mark Kettenis > CC: brobecker@adacore.com, andrew.smirnov@gmail.com, > gdb-patches@sourceware.org > > Since there is absolutely no problem with a local variable that has > the same name as a library function, this is bad. You are, in effect, saying that the wisdom of coding "down the middle of a programming language" is wrong. We will have to disagree on that, sorry. FWIW, I don't think a large project should live dangerously just because some versions of some compiler will flag these clashes even without -Wshadow.