From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8805 invoked by alias); 28 Feb 2013 15:54:32 -0000 Received: (qmail 8796 invoked by uid 22791); 28 Feb 2013 15:54:31 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Feb 2013 15:54:27 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MIX00E00T720J00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Thu, 28 Feb 2013 17:54:25 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MIX00DI4TINKFB0@a-mtaout20.012.net.il>; Thu, 28 Feb 2013 17:54:23 +0200 (IST) Date: Thu, 28 Feb 2013 16:30:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 1/4] Fix dprintf bugs In-reply-to: <1362057362-25324-1-git-send-email-yao@codesourcery.com> To: Yao Qi Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83a9qowi1b.fsf@gnu.org> References: <1361192891-29341-1-git-send-email-yao@codesourcery.com> <1362057362-25324-1-git-send-email-yao@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00742.txt.bz2 > From: Yao Qi > Date: Thu, 28 Feb 2013 21:15:59 +0800 > > This patch fixes PR15075. Besides this bug, this patch also fixes > some other problems: > > - Two dprintf are set on the same address. Only one printf is > executed. > - dprintf and regular breakpoint are set on the same address, > inferior doesn't stop. > > In order to fix these problems, I don't append "continue" command to > dprintf breakpoint, and execute commands of dprintf after > bpstat_check_breakpoint_conditions if condition is true. The reason I > choose this place (after bpstat_check_breakpoint_conditions instead of > in bpstat_check_breakpoint_conditions) to handle dprintf is that we > have to set BS->stop to zero, but have to update hit count if > condition is true, so we have to do two things together. > > With this patch, GDB executes dprintf commands after > bpstat_check_breakpoint_conditions, the different place where > breakpoint commands are executed. I propose to disable setting > command for dprintf, or disallow user setting commands for dprintf. I don't understand: if you are disallowing commands for dprintf, then why do you also fix the handling of these commands?