From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13728 invoked by alias); 30 Oct 2013 15:41:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13710 invoked by uid 89); 30 Oct 2013 15:41:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout21.012.net.il Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Oct 2013 15:41:04 +0000 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MVH00900NIN4100@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Wed, 30 Oct 2013 17:41:02 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MVH008D3NKDWX90@a-mtaout21.012.net.il>; Wed, 30 Oct 2013 17:41:02 +0200 (IST) Date: Wed, 30 Oct 2013 15:41:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Extra error message from update_watchpoint In-reply-to: <5270F23E.7010602@broadcom.com> To: Andrew Burgess Cc: palves@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83a9hqepgt.fsf@gnu.org> References: <5260FD66.7090506@broadcom.com> <52616D4B.3020209@redhat.com> <526FE5E9.3000909@broadcom.com> <83ob68dmfb.fsf@gnu.org> <526FF27B.8090209@broadcom.com> <5270F23E.7010602@broadcom.com> X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00924.txt.bz2 > Date: Wed, 30 Oct 2013 11:49:18 +0000 > From: "Andrew Burgess" > cc: gdb-patches@sourceware.org > > OK, here are a few alternatives, feel free to pick your favourites: > > (1) The original: > error (_("Software read/access watchpoints not supported.")); > > (2) Pedro's original replacement: > error (_("Hardware watchpoint support disabled. " > "See set/show can-use-hw-watchpoints.")); > > (3) The original + why we can't use H/W watchpoints (bit long): > error (_("Software read/access watchpoints not supported, " > "re-enable hardware watchpoints using " > "\"set can-use-hw-watchpoints 1\"")); > > (4) Same, but with a newline to keep it under 80 chars, not sure if > multi-line errors are acceptable though. > error (_("Software read/access watchpoints not supported.\n" > "Enable hardware watchpoints using " > "\"set can-use-hw-watchpoints 1\"")); > > (5) Mention that H/W watchpoints are disabled, but not how to re-enable > them, though given the user has done the disabling this might be enough > to prompt them. This is single line, and just under 80 chars. > error (_("Software read/access watchpoints not supported, " > "hardware watchpoints disabled.")); > > > My favourite is (5) at the moment, but I'll take whatever makes everyone > else happy :) None of the above really explains to the user why GDB is going to refuse to abide by her command. A good message should say something like "Cannot do SOMETHING because SOME-REASON." But I don't want to be in the position of blocking a commit due to something that is just MO, so feel free to ignore me.