From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9957 invoked by alias); 9 Dec 2013 16:34:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9943 invoked by uid 89); 9 Dec 2013 16:34:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout22.012.net.il Received: from Unknown (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Dec 2013 16:34:12 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MXJ00B00SMJZ700@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Mon, 09 Dec 2013 18:33:42 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MXJ00B0HSO66SE0@a-mtaout22.012.net.il>; Mon, 09 Dec 2013 18:33:42 +0200 (IST) Date: Mon, 09 Dec 2013 16:34:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] gdb: set filename-display shortpath support In-reply-to: <1386579696-26136-1-git-send-email-a3at.mail@gmail.com> To: Azat Khuzhin Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83a9gayoez.fsf@gnu.org> References: <1386579696-26136-1-git-send-email-a3at.mail@gmail.com> X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00344.txt.bz2 > From: Azat Khuzhin > Cc: Azat Khuzhin > Date: Mon, 9 Dec 2013 13:01:36 +0400 > > Display only non-common part of filename and compilation directory Thanks. > + for (;;) > + { > + size_t min_part_len; > + > + slash_name = strstr (slash_name, SLASH_STRING); > + slash_dir = strstr (slash_dir, SLASH_STRING); > + if (slash_name == NULL || slash_dir == NULL) > + break; It is wrong to use SLASH_STRING to search for directory separators; that is non-portable. SLASH_STRING is for constructing file names from directories and the basename. To look for directory separators, please use lbasename, ldirname, or similar functions, which already know about possible separators on each supported platform. > @@ -2093,9 +2137,11 @@ is not specified, print all substitution rules."), > Set how to display filenames."), _("\ > Show how to display filenames."), _("\ > filename-display can be:\n\ > - basename - display only basename of a filename\n\ > - relative - display a filename relative to the compilation directory\n\ > - absolute - display an absolute filename\n\ > + basename - display only basename of a filename\n\ > + relative - display a filename relative to the compilation directory\n\ > + absolute - display an absolute filename\n\ > + shortpath - display only non-common part of filename and compilation \ > +directory\n\ This should use "filenames", not "a filename", since the option affects any displayed file name, not just one of them. > By default, relative filenames are displayed."), This is ambiguous. I suggest to say "The default is \"relative\"." Sorry for not paying attention when you first posted the patch.