From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123216-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 72966 invoked by alias); 28 May 2015 14:42:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 72957 invoked by uid 89); 28 May 2015 14:42:07 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout27.012.net.il
Received: from mtaout27.012.net.il (HELO mtaout27.012.net.il) (80.179.55.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 May 2015 14:42:05 +0000
Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NP200900DN2PQ00@mtaout27.012.net.il> for gdb-patches@sourceware.org; Thu, 28 May 2015 17:37:17 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NP20016UDY5RG90@mtaout27.012.net.il>; Thu, 28 May 2015 17:37:17 +0300 (IDT)
Date: Thu, 28 May 2015 14:42:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Unbreak DJGPP port of GDB
In-reply-to: <86iobdozr0.fsf@gmail.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83a8woydaj.fsf@gnu.org>
References: <83zj4uypea.fsf@gnu.org> <86iobdozr0.fsf@gmail.com>
X-IsSubscribed: yes
X-SW-Source: 2015-05/txt/msg00688.txt.bz2

> From: Yao Qi <qiyaoltc@gmail.com>
> Cc: gdb-patches@sourceware.org
> Date: Thu, 28 May 2015 09:46:59 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > It turns out the DJGPP (a.k.a. "go32") port of GDB was broken more
> > than a year ago, by commits 9b40951 and bd265cd.  It stayed broken
> > ever since.  Lately, Andris Pavenis bisected the bug and posted the
> > results here:
> >
> >   http://www.delorie.com/djgpp/mail-archives/browse.cgi?p=djgpp/2015/05/24/04:17:40
> >
> > Looking into those changesets, I've found that the problem was due to
> > incorrect handling of values returned by functions 'read_child' and
> > 'write_child', which are part of the DJGPP native debug support.
> 
> It is broken by my to_xfer_partial patches... sorry about that.

No sweat.  I should have been more vigilant in reviewing those patches
anyway.

> > The patch below fixes that.  I will push it in a few days (with an
> > appropriate ChangeLog entry), if no one objects.
> 
> The patch looks right to me.

Thanks.