From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120605 invoked by alias); 17 Jun 2015 16:42:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120569 invoked by uid 89); 17 Jun 2015 16:42:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout20.012.net.il Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Jun 2015 16:42:12 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NQ300B00KZQCM00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Wed, 17 Jun 2015 19:42:09 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQ300B3OL286P50@a-mtaout20.012.net.il>; Wed, 17 Jun 2015 19:42:09 +0300 (IDT) Date: Wed, 17 Jun 2015 16:42:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 1/5] Introduce build_debug_file_name In-reply-to: <20150617094734.GA9671@blade.nx> To: Gary Benson Cc: gdb-patches@sourceware.org, cedric.buissart@gmail.com Reply-to: Eli Zaretskii Message-id: <83a8vymgmg.fsf@gnu.org> References: <1434447768-17328-1-git-send-email-gbenson@redhat.com> <1434447768-17328-2-git-send-email-gbenson@redhat.com> <83zj3zn21q.fsf@gnu.org> <20150617094734.GA9671@blade.nx> X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00368.txt.bz2 > Date: Wed, 17 Jun 2015 10:47:34 +0100 > From: Gary Benson > Cc: gdb-patches@sourceware.org, cedric.buissart@gmail.com > > For the case you mention nothing would be stripped (the "d" in that > path is !IS_DIR_SEPARATOR) so the filename components would be > concatenated verbatim, just as with the original code. The resulting > filename may not make sense, but it's not a regression. But won't we produce "d://foo/bar" as result? > I don't believe this series should be blocked unless it breaks > something that actually worked before. If a fix is very simple, why not make it?