From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43434 invoked by alias); 13 Jun 2017 19:23:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43416 invoked by uid 89); 13 Jun 2017 19:23:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=nonetheless, act X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Jun 2017 19:23:05 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKrP6-0008Ry-2S for gdb-patches@sourceware.org; Tue, 13 Jun 2017 15:23:08 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKrP5-0008Rr-Uf; Tue, 13 Jun 2017 15:23:03 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4868 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dKrP3-00070S-1W; Tue, 13 Jun 2017 15:23:03 -0400 Date: Tue, 13 Jun 2017 19:23:00 -0000 Message-Id: <83a85b4rrs.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: qiyaoltc@gmail.com, gdb-patches@sourceware.org In-reply-to: (message from Simon Marchi on Tue, 13 Jun 2017 19:07:29 +0200) Subject: Re: [PATCH 0/5] Remove a few hurdles of compiling with clang Reply-to: Eli Zaretskii References: <1497124689-11842-1-git-send-email-simon.marchi@ericsson.com> <83tw3n5jyk.fsf@gnu.org> <86tw3labb0.fsf@gmail.com> <83a85d5l4n.fsf@gnu.org> <93eb64489ac9d53665a144ddf5a966d5@polymtl.ca> <83wp8h40lo.fsf@gnu.org> <8660g0dzau.fsf@gmail.com> <83k24g3qcx.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00401.txt.bz2 > Date: Tue, 13 Jun 2017 19:07:29 +0200 > From: Simon Marchi > Cc: Simon Marchi , qiyaoltc@gmail.com, > gdb-patches@sourceware.org > > > Does clang have the equivalent of "#pragma push"? If it does, we > > could disable this warning only for clang and only for that code > > snippet. > > That's indeed a solution, but I'd keep that for the cases where we can't > find an elegant solution that pleases both GCC and Clang. See, I don't consider the proposed solution to be elegant, because it tweaks a perfectly valid code to placate a stupid compiler warning. Someone at some point might rightfully ask why didn't we use ALL_DEBUG_ADDRESS_REGISTERS instead, and might even reinstate the code you are about to change. So I prefer to have a seemingly "ugly" workaround, which nonetheless points out exactly which warning of what compiler caused it. That way, at some future point, when clang hopefully gets its act together, we could revisit the issue and see that the workaround is no longer needed.