Re: [ANNOUNCEMENT] GDB 8.1 release branch created!

Yao Qi
2018-02-01T15:12:56Z

Eli Zaretskii <eliz@gnu.org> writes:

> No further comments, so I went ahead and pushed the change, without
> the __cplusplus part, to master, and then cherry-picked to
> gdb-8.1-branch.

Hi Eli,
Is it intended to include error messages in the changelog entry? If
not, can we remove it? in the patch below,

2018-01-27 Eli Zaretskii <eliz@gnu.org>

Avoid compilation errors in MinGW native builds

The error is triggered by including python-internal.h, and the
error message is:

In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
from build-gnulib/import/math.h:27,
from d:/usr/Python26/include/pyport.h:235,
from d:/usr/Python26/include/Python.h:58,
from python/python-internal.h:94,
from python/py-arch.c:24:
d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
using ::hypot;
^~~~~

This happens because Python headers define 'hypot' to expand t
'_hypot' in the Windows builds.
* python/python-internal.h (_hypot) [__MINGW32__]: Define back to
'hypoth'. This avoids a compilation error.

--
Yao (齐尧)
From 65951173ddd802b5c26f3f706ad845f41dc78f8b Mon Sep 17 00:00:00 2001
From: Yao Qi <yao.qi@linaro.org>
Date: Thu, 1 Feb 2018 15:11:46 +0000
Subject: [PATCH] Remove unnecessary bits from ChangeLog

Remove something shouldn't be put in ChangeLog.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5c3338f..40f4008 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -144,23 +144,6 @@

2018-01-27 Eli Zaretskii <eliz@gnu.org>

- Avoid compilation errors in MinGW native builds
-
- The error is triggered by including python-internal.h, and the
- error message is:
-
- In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
- from build-gnulib/import/math.h:27,
- from d:/usr/Python26/include/pyport.h:235,
- from d:/usr/Python26/include/Python.h:58,
- from python/python-internal.h:94,
- from python/py-arch.c:24:
- d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
- using ::hypot;
- ^~~~~
-
- This happens because Python headers define 'hypot' to expand t
- '_hypot' in the Windows builds.
* python/python-internal.h (_hypot) [__MINGW32__]: Define back to
'hypoth'. This avoids a compilation error.