From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5114 invoked by alias); 29 Aug 2018 19:16:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5085 invoked by uid 89); 29 Aug 2018 19:16:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 19:16:52 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fv5xO-0001fk-5T for gdb-patches@sourceware.org; Wed, 29 Aug 2018 15:16:51 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fv5xO-0001fe-0j; Wed, 29 Aug 2018 15:16:46 -0400 Received: from [176.228.60.248] (port=1733 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fv5xM-0002Nh-T5; Wed, 29 Aug 2018 15:16:45 -0400 Date: Wed, 29 Aug 2018 19:16:00 -0000 Message-Id: <83a7p52dbh.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: palves@redhat.com, gdb-patches@sourceware.org In-reply-to: <87efeh3snr.fsf@tromey.com> (message from Tom Tromey on Wed, 29 Aug 2018 12:59:52 -0600) Subject: Re: [PATCH] Fix windows-nat.c for -Wnarrowing References: <20180829174253.18507-1-tom@tromey.com> <88f0fbca-f10a-9139-f96a-7934e10a937c@redhat.com> <87in3t3sqb.fsf@tromey.com> <87efeh3snr.fsf@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00770.txt.bz2 > From: Tom Tromey > Cc: Pedro Alves , gdb-patches@sourceware.org > Date: Wed, 29 Aug 2018 12:59:52 -0600 > > >>>>> "Tom" == Tom Tromey writes: > > Tom> So, I've added a DWORD cast there as well; then restore the #if. > > That's not going to work either, is it? > Since the test is > > for (i = 0; xlate[i].them != -1; i++) > > ... and it should be for (DWORD) -1 ? Why did you need to make .them be DWORD? I think it should be a 'long', and then you can use -1L without any trouble.