From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56203 invoked by alias); 3 Sep 2018 18:58:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56187 invoked by uid 89); 3 Sep 2018 18:58:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*tom, H*r:4.82, H*r:TLS1.2, H*r:2001 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Sep 2018 18:58:30 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fwu3L-0001r4-Py for gdb-patches@sourceware.org; Mon, 03 Sep 2018 14:58:28 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fwu3L-0001r0-MG; Mon, 03 Sep 2018 14:58:23 -0400 Received: from [176.228.60.248] (port=2734 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fwu3L-0002BY-A4; Mon, 03 Sep 2018 14:58:23 -0400 Date: Mon, 03 Sep 2018 18:58:00 -0000 Message-Id: <83a7oyz9vc.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <20180903184300.9961-4-tom@tromey.com> (message from Tom Tromey on Mon, 3 Sep 2018 12:43:00 -0600) Subject: Re: [RFC 3/3] Deprecate and replace the "tabset" command References: <20180903184300.9961-1-tom@tromey.com> <20180903184300.9961-4-tom@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00025.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey > Date: Mon, 3 Sep 2018 12:43:00 -0600 > > The "tabset" command sets the tab width as used by the TUI for source > and disassembly display. > > This command has long seemed to be misnamed to me. It is more in > keeping with gdb design to call it "set tui tab-width". Also, making > this change allows for the corresponding "show" command to work. > > gdb/ChangeLog > 2018-09-03 Tom Tromey > > PR tui/18388: > * NEWS: Mention tabset deprecation. > * tui/tui-win.c (tui_tab_width, internal_tab_width): New globals. > (update_tab_width): New function. > (tui_set_tab_width, tui_show_tab_width): New functions. > (tui_set_tab_width_command): Use update_tab_width. > (_initialize_tui_win): Move to end of file. Deprecate "tabset". > Add new "set tui tab-width" command. > * tui/tui-source.c (tui_set_source_content): Update. > * tui/tui-disasm.c (tui_set_disassem_content): Update. > * tui/tui-data.h (tui_default_tab_len, tui_set_default_tab_len): > Don't declare. > (tui_tab_width): Declare. > * tui/tui-data.c (default_tab_len, tui_default_tab_len) > (tui_set_default_tab_len): Remove. > > gdb/doc/ChangeLog > 2018-09-03 Tom Tromey > > PR tui/18388: > * gdb.texinfo (TUI Commands): Remove tabset documentation. > (TUI Configuration): Document "set tui tab-width". OK for the documentation parts. Thanks.