From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 9BDCE3893646
 for <gdb-patches@sourceware.org>; Thu, 11 Jun 2020 13:28:05 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9BDCE3893646
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:33430)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jjNFV-0001eo-2j; Thu, 11 Jun 2020 09:28:05 -0400
Received: from [176.228.60.248] (port=3519 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jjNFS-0002VC-CX; Thu, 11 Jun 2020 09:28:03 -0400
Date: Thu, 11 Jun 2020 16:27:45 +0300
Message-Id: <83a71968by.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <1247d74ec150f017e7ac1fea946af1d3da7ea79e.1591871818.git.andrew.burgess@embecosm.com>
 (message from Andrew Burgess on Thu, 11 Jun 2020 11:41:31 +0100)
Subject: Re: [PATCH 2/2] gdb: New maintenance command to print XML target
 description
References: <cover.1591871818.git.andrew.burgess@embecosm.com>
 <1247d74ec150f017e7ac1fea946af1d3da7ea79e.1591871818.git.andrew.burgess@embecosm.com>
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Jun 2020 13:28:06 -0000

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Thu, 11 Jun 2020 11:41:31 +0100
> 
> gdbsupport/ChangeLog:
> 
> 	* tdesc.cc (print_xml_feature::visit_pre): Use add_line to add
> 	output content, and call indent as needed in all overloaded
> 	variants.
> 	(print_xml_feature::visit_post): Likewise.
> 	(print_xml_feature::visit): Likewise.
> 	(print_xml_feature::add_line): Two new overloaded functions.
> 	* tdesc.h (print_xml_feature::indent): Declare new member
> 	function.
> 	(print_xml_feature::add_line): Two new overloaded member
> 	functions.
> 
> gdb/ChangeLog:
> 
> 	* target-descriptions.c (tdesc_architecture_name): Protect against
> 	NULL pointer dereference.
> 	(class gdb_print_xml_feature): New class.
> 	(maint_print_xml_tdesc_cmd): New function.
> 	(_initialize_target_descriptions): Register new 'maint print
> 	xml-tdesc' command and give it the filename completer.
> 	* NEWS: Mention new 'maint print xml-tdesc' command.
> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.xml/maint-xml-dump-01.xml: New file.
> 	* gdb.xml/maint-xml-dump-02.xml: New file.
> 	* gdb.xml/maint-xml-dump.exp: New file.
> 
> gdb/doc/ChangeLog:
> 
> 	* gdb.texinfo (Maintenance Commands): Document new 'maint print
> 	xml-desc' command.

OK for the documentation changes.

Thanks.