From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id b+cOGs77pGCCOAAAWB0awg (envelope-from ) for ; Wed, 19 May 2021 07:51:42 -0400 Received: by simark.ca (Postfix, from userid 112) id 5B53B1F11C; Wed, 19 May 2021 07:51:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0312B1E54D for ; Wed, 19 May 2021 07:51:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 54D613857C48; Wed, 19 May 2021 11:51:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 54D613857C48 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1621425100; bh=dOKdWFgav3pnEAT5WQF4ozTFTde+XiWmOC/iq/K0Yoo=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=s+zNEYN9JQSRPsZvvc7BVDScPD4DdGotXspNIH9WuCNPK6re5mGPkMnHFj230kx56 JyXbIOwG3yL7ExqqNbDCb3Mb2gmbTKhRdZv/2ki4oE/tzkD/p1lVs8Srl5ejzwwEaa DIZ+SYnHJeJMLHzpgoSkrGetg1nYGc5kAHzFs2Iw= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 682F83857C48 for ; Wed, 19 May 2021 11:51:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 682F83857C48 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45602) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljKjf-0006uf-VA; Wed, 19 May 2021 07:51:35 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2802 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljKjf-0007VD-GV; Wed, 19 May 2021 07:51:35 -0400 Date: Wed, 19 May 2021 14:51:43 +0300 Message-Id: <83a6orq6uo.fsf@gnu.org> To: Andrew Burgess In-Reply-To: (message from Andrew Burgess on Wed, 19 May 2021 12:12:40 +0100) Subject: Re: [PATCHv2 3/5] gdb/mi: add regexp filtering to -file-list-exec-source-files References: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > From: Andrew Burgess > Date: Wed, 19 May 2021 12:12:40 +0100 > > This commit extends the existing MI command > -file-list-exec-source-files to provide the same regular expression > based filtering that the equivalent CLI command "info sources" > provides. > > The new command syntax is: > > -file-list-exec-source-files [--basename | --dirname] [--] [REGEXP] Thanks. > + ** '-file-list-exec-source-files [--basename | --dirname] [--] [REGEXP]' > + > + The existing -file-list-exec-source-files command now takes an > + optional REGEXP which is used to filter the source files that are > + included in the results. By default REGEXP is matched against the > + full filename of the source file. > + > + When one of --basename or --dirname is given then REGEXP is only > + matched against the specified part of the full source filename. It is better to make the last sentence of the first paragraph to be the first sentence of the second paragraph, since these describe the same aspect of using REGEXP. > +This commands returns information about the source files @value{GDBN} > +knows about, it will output both the filename and fullname (absolute > +file name) of a source file, though the fullname can be elided if this > +information is not known. ^^^^^^^^^^^^ I'd suggest to say "is not known to @value{GDBN}", to make the issue more clear. > +name of the source file can't be computed. The field ^^ Two spaces between sentences, please (here and elsewhere). > +@var{debug-fully-read} will be a string, either @code{true} or > +@code{false}. When @code{true} this indicates the full debug ^ Comma is missing there. > +information for the compilation unit describing this file has been > +read in. When @code{false} the full debug information has not yet ^ And there. > +@value{GDBN} interpreting @var{regexp} as a command option (e.g. if > +@var{regexp} starts with @samp{-}). Please add either a comma or "@:" (without quotes) after "e.g.", so that TeX won't interpret that as ending a sentence. > +If @code{--dirname} is provided then @var{regexp} is matched only ^ Comma missing. > +against the directory name of each source file. If @code{--basename} > +is provided then @var{regexp} is matched against the basename of each ^ And here.