From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0GkwGFwBgmhsODsAWB0awg (envelope-from ) for ; Thu, 24 Jul 2025 05:48:12 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=cSmHH90r; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sMGGcDqk; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=cSmHH90r; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sMGGcDqk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 49F211E102; Thu, 24 Jul 2025 05:48:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0AE4B1E091 for ; Thu, 24 Jul 2025 05:48:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 990DF3858C78 for ; Thu, 24 Jul 2025 09:48:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 990DF3858C78 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=cSmHH90r; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sMGGcDqk; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=cSmHH90r; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sMGGcDqk Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 7D2B13858D33 for ; Thu, 24 Jul 2025 09:47:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D2B13858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7D2B13858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753350457; cv=none; b=oHrEc924e1xk6xSxBNjaeyWuj/LGwZgZnj+53+NBk3/ZpvWZ+5TJyUsSFmmZSNF75JpGWAmSRHIj3i3uk9X+BmaUQcXc6AEZdsaNEfQc6sp52UUwTi/x33O91Iy2Z87faiwhWvSibTzbtySNMnHJduMdFaMwXCJIL20s1e2fDf8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1753350457; c=relaxed/simple; bh=HPpUEac/1kWrou8oVhtnolfun1/KSScoLyLOvkTbq/g=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=S45z6Q/twjCm3sHi1q3xtZg6q2vtPEnprNghoPDDmG13/2076qHLNtw8JZJezLOtb7MRxKJEhb3S2cete5aDXUc1apQuvD9XSqb7EzY9l1WeJWYRRMcJ121oTz5frPffH/SgXjJMIoKP3OE1D8TG90Y1pb0/Hq3fTx6faEwznWA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D2B13858D33 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7EF4021979; Thu, 24 Jul 2025 09:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753350456; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e0bg628HWEXXZqwvwuPV0JbKiMqLLSxxyZEoARBV2ms=; b=cSmHH90rYXBi90wJ9OPT77qHvZOOKe0d/T8GGHDTVjw2o4MlQfxRYlGQ45YfE+UTlKYkhX tvU2SCNwm+tkudz1MOlyPngXVmB84Y96J6MuKyZ7qCEARi35VUkgP4P0hFCJnTn+WX+jCJ XC91MJn5CNq3chrPFYtTKFOu1tdx63A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753350456; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e0bg628HWEXXZqwvwuPV0JbKiMqLLSxxyZEoARBV2ms=; b=sMGGcDqkvcP2MrcNjnhDxo1heoVbPfZkhyLnwNo9jlOTkuwEBudTIgCal0s9WB9nChJBBO SAq0LpzerLynMVCw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753350456; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e0bg628HWEXXZqwvwuPV0JbKiMqLLSxxyZEoARBV2ms=; b=cSmHH90rYXBi90wJ9OPT77qHvZOOKe0d/T8GGHDTVjw2o4MlQfxRYlGQ45YfE+UTlKYkhX tvU2SCNwm+tkudz1MOlyPngXVmB84Y96J6MuKyZ7qCEARi35VUkgP4P0hFCJnTn+WX+jCJ XC91MJn5CNq3chrPFYtTKFOu1tdx63A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753350456; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e0bg628HWEXXZqwvwuPV0JbKiMqLLSxxyZEoARBV2ms=; b=sMGGcDqkvcP2MrcNjnhDxo1heoVbPfZkhyLnwNo9jlOTkuwEBudTIgCal0s9WB9nChJBBO SAq0LpzerLynMVCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 63B2813302; Thu, 24 Jul 2025 09:47:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rGKjFjgBgmgJWgAAD6G6ig (envelope-from ); Thu, 24 Jul 2025 09:47:36 +0000 Message-ID: <83a142c8-6eee-4b0b-a6ef-73d7d116eb94@suse.de> Date: Thu, 24 Jul 2025 11:47:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/7] [gdb/testsuite] Use TERM=ansiw in tuiterm for bsd To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250718130153.24989-1-tdevries@suse.de> <20250718130153.24989-7-tdevries@suse.de> <878qkeu565.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <878qkeu565.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/23/25 20:34, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> So I went looking for an alternative to TERM=ansi on freebsd, and came across > Tom> TERM=ansiw. Using this didn't work out of the box, but with the fixes in > Tom> this series it now does. > > Tom> I also briefly looked at TERM=ansis, which is interesting because it's > Tom> available on both linux and freebsd, but ansiw is a better choice for now. > > I wonder if we should just give in and switch to xterm. > I've filed a PR ( https://sourceware.org/bugzilla/show_bug.cgi?id=33206 ). > Tom> proc _have_bw {} { > Tom> + if { [string equal $Term::_TERM "ansiw"] } { > Tom> + return 1 > Tom> + } > Tom> return 0 > > This can be just return [string ... ] > Thanks for the review, fixed and pushed. > It seems like it could just as easily check $env(TERM) and avoid another > variable as well. Say we add this to gdb.tui.basic.exp: ... +puts "$env(TERM)" Term::clean_restart 24 80 $testfile +puts "$env(TERM)" ... and run the test-case, we get: ... dumb dumb ... So that wouldn't work. The env(TERM) var is only set for the duration of starting gdb. Thanks, - Tom