From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18423 invoked by alias); 11 Apr 2009 11:25:05 -0000 Received: (qmail 18403 invoked by uid 22791); 11 Apr 2009 11:25:05 -0000 X-SWARE-Spam-Status: No, hits=0.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_JMF_BL,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout5.012.net.il (HELO mtaout5.012.net.il) (84.95.2.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 11 Apr 2009 11:24:58 +0000 Received: from conversion-daemon.i_mtaout5.012.net.il by i_mtaout5.012.net.il (HyperSendmail v2004.12) id <0KHX00J00OAD8200@i_mtaout5.012.net.il> for gdb-patches@sourceware.org; Sat, 11 Apr 2009 14:24:54 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.229.240.185]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KHX00G1JP1HVR70@i_mtaout5.012.net.il>; Sat, 11 Apr 2009 14:24:54 +0300 (IDT) Date: Sat, 11 Apr 2009 11:25:00 -0000 From: Eli Zaretskii Subject: Re: [patch] [1/5] Types reference counting [base] In-reply-to: <20090411102044.GB32624@host0.dyn.jankratochvil.net> To: Jan Kratochvil Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <838wm7301j.fsf@gnu.org> References: <20090411102044.GB32624@host0.dyn.jankratochvil.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00205.txt.bz2 > Date: Sat, 11 Apr 2009 12:20:45 +0200 > From: Jan Kratochvil > > a base implementation of types reference counting. Thanks. > gdb/doc/ Thanks, I have a few comments about this part of your patch. > 2009-04-11 Jan Kratochvil > > * gdbint.texinfo (Symbol Handling): New anchor `Builtin Types'. Move > types `from Memory Management for Symbol Files' to a new subsection > `Memory Management for Types'. Please also add in the log an entry which explicitly says that `Memory Management for Types' was added ("New node."). See below. > +@subsection Memory Management for Types I'd prefer not to have sections without an associated @node. Such a manual is harder to navigate. Please add a @node here. That's assuming that having a separate subsection here is justified; maybe it isn't. Also, a @cindex entry (with the same text as the subsection name, only in lower case) would be useful here. > +@code{TYPE_OBJFILE} macro indicates the current memory owner of the type. It would be good to have a @findex entry for each macro you describe (TYPE_OBJFILE etc.). > +@code{TYPE_OBJFILE} set to @code{NULL} and become so called reclaimable types. "so-called", with a dash, and I suggest a @dfn around "reclaimable types", since you are introducing new terminology. > +Types with @code{NULL TYPE_OBJFILE} can be either permanent types Please don't put @code around several separate words, because that causes the whitespace to be typeset incorrectly. Please use a separate @code for each word. Actually, I'd reword this as Types with @code{TYPE_OBJFILE} set to @code{NULL} can be .. or Types with null @code{TYPE_OBJFILE} can be ... > +(@pxref{Builtin Types}) or reclaimable types which will be deallocated after the > +last object referencing them is removed. But the text below says that actually they will be deallocated only when GDB becomes idle, right? > +as through @code{TYPE_TARGET_TYPE}, @code{TYPE_POINTER_TYPE} etc. and prevents ^^ Please add either a @: or a comma after any period that doesn't end a sentence, so that TeX would not typeset that as a sentence end.