From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4931 invoked by alias); 12 Jan 2010 19:31:34 -0000 Received: (qmail 4917 invoked by uid 22791); 12 Jan 2010 19:31:33 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jan 2010 19:31:26 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0KW500900DJH4A00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 12 Jan 2010 21:31:21 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.126.60.183]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KW5007LYFK711B0@a-mtaout22.012.net.il>; Tue, 12 Jan 2010 21:31:20 +0200 (IST) Date: Tue, 12 Jan 2010 19:31:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Trace file support In-reply-to: <4B4BD994.9070701@codesourcery.com> To: Stan Shebs Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <838wc386hd.fsf@gnu.org> References: <4B4BD994.9070701@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00311.txt.bz2 > Date: Mon, 11 Jan 2010 18:08:20 -0800 > From: Stan Shebs > > This patch adds support for trace files, which are simply dumps of a > target's tracepoints and trace buffer. In addition to the new "tsave" > command to create a trace file, there is a new target "tfile" that opens > a trace file and then lets you do tfind and then print any data that was > collected, just as for you would do for a live target. Thanks, I have a few comments about this part: > * gdb.texinfo (Trace Files): New section. > (Tracepoint Packets): Document QTSave and qTBuffer. > + It is also possible to get trace data from a file, in a manner reminiscent > + of corefiles; you specify the filename, and use @code{tfind} to search > + through the file. See @ref{Trace Files} for more details. ^ You need a comma here, or else makeinfo will bitch at you. Also, "See @ref" at the beginning of a sentence is exactly equivalent to "@xref", so might as well use that. > + then save it. If the target supports it, you can also supply the > + optional argument @code{-r} (``remote'') to direct the target to save > + the data directly into @var{filename} in its filesystem, which may be > + more efficient if the trace buffer is very large. > + > + @kindex target tfile > + @kindex tfile > + @item target tfile @var{filename} > + Use the given @var{filename} as a source of trace data. This leaves me wondering: how would "target tfile" know whether to look on the host or on the target for the specified file? How about clarifying that? > + The trace file comes in three parts: a header, a textual description > + section, and a trace frame section with binary data. [...] I wonder if we really need such a detailed description of the file's format in the user manual. Who would need that? can we simply send the interested reader to some header file? > + The description section consists of multiple lines of ASCII text @sc{ascii} will look better in print, I think. Or try @acronym{ASCII}. > + Memory block. This is a contiguous block of memory, at the 8-byte ^ Not enough spaces ;-) Thanks.