From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21182 invoked by alias); 1 Apr 2010 13:30:32 -0000 Received: (qmail 21147 invoked by uid 22791); 1 Apr 2010 13:30:31 -0000 X-SWARE-Spam-Status: No, hits=1.8 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_JMF_BL,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Apr 2010 13:30:26 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0L0700L009I4C900@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Thu, 01 Apr 2010 16:30:13 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.124.92.42]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L0700JBP9IC8P50@a-mtaout23.012.net.il>; Thu, 01 Apr 2010 16:30:13 +0300 (IDT) Date: Thu, 01 Apr 2010 13:30:00 -0000 From: Eli Zaretskii Subject: Re: [PING][RFC-v4] Add windows OS Thread Information Block In-reply-to: <001201cad17f$6a058980$3e109c80$%muller@ics-cnrs.unistra.fr> To: Pierre Muller Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <838w97xpui.fsf@gnu.org> References: <000901c9f5ef$4ee06f10$eca14d30$@u-strasbg.fr> <201003101725.48298.pedro@codesourcery.com> <000c01cac0a0$3935fbe0$aba1f3a0$%muller@ics-cnrs.unistra.fr> <201003110000.31184.pedro@codesourcery.com> <002101cac0f2$a2298890$e67c99b0$%muller@ics-cnrs.unistra.fr> <000e01cac488$27dcf970$7796ec50$%muller@ics-cnrs.unistra.fr> <001201cad17f$6a058980$3e109c80$%muller@ics-cnrs.unistra.fr> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00012.txt.bz2 > From: "Pierre Muller" > Date: Thu, 1 Apr 2010 11:40:50 +0200 > > I am still waiting for a comment from any global > maintainer concerning the non-(windows specific) parts > of that patch. Christopher approved the windows part. Sorry I missed that. > > + if (target_get_tib_address (ptid, &thread_local_base) == 0) > > + { > > + printf_filtered ("Unable to get thread local base for ThreadId > > %s\n", > > + pulongest (ptid_get_tid(ptid))); Please add _() around the user messages. > > + printf_filtered ("Unable to read thread information block for > > ThreadId %s at address %s\n", > > + pulongest (ptid_get_tid (ptid)), > > + paddress (target_gdbarch, thread_local_base)); Ditto. > > + printf_filtered ("Thread Information Block %s at %s\n", > > + pulongest (ptid_get_tid (ptid)), > > + paddress (target_gdbarch, thread_local_base)); Ditto. > > + printf_filtered ("%s is 0x%s\n", TIB_NAME [i], phex (val, size)); > > + else if (val != 0) > > + printf_filtered ("TIB[0x%s] is 0x%s\n", phex (i*size, 2), > > + phex (val, size)); Ditto. > > + add_prefix_cmd ("w32", class_info, info_w32_command, > > + _("Print information specific to Win32 debugging."), RMS would say "don't call Windows ``a win''". > > +If enabled, all non-zero fields of thread information block are displayed,\n\ > > +even if its meaning is unknown."), "its" is inappropriate here, as "fields" are in plural. I suggest "their" instead. > > +@item $_tlb > > +@vindex $_tlb@r{, convenience variable} > > +The variable @code{$_tlb} is automatically set for Windows OS running > > +applications in native mode or connected to a gdbserver that supports This is backwards: it makes it sound like we set the variable for Windows, not for the application. I suggest the following alternative wording: The variable @code{$_tlb} is automatically set when debugging applications running on MS-Windows in native mode or connected to gdbserver that supports the @code{qGetTIBAddr} request. Please also add an @xref to where the qGetTIBAddr packet is described. > > +@code{qGetTIBAddr} requests. This variable contains the address of the ^^ Two spaces between sentences, please. > > +@tab Display Windows OS Thread Information Block. "Display MS-Windows Thread Information Block." > > +An error occured. This means that either the thread was not found, or ^^ Two spaces. The patch for the manual is okay with the above changes.