From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21631 invoked by alias); 26 Apr 2010 17:56:13 -0000 Received: (qmail 21617 invoked by uid 22791); 26 Apr 2010 17:56:12 -0000 X-SWARE-Spam-Status: No, hits=1.8 required=5.0 tests=BAYES_00,RCVD_IN_JMF_BL,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Apr 2010 17:56:06 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0L1H00M00WCWM600@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Mon, 26 Apr 2010 20:55:35 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.127.125.239]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L1H00KNVWGJYX50@a-mtaout20.012.net.il>; Mon, 26 Apr 2010 20:55:32 +0300 (IDT) Date: Mon, 26 Apr 2010 17:56:00 -0000 From: Eli Zaretskii Subject: Re: [python][patch] Add GDB Parameters functionality In-reply-to: <4BD592D9.1070801@redhat.com> To: Phil Muldoon Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <838w8ayu7a.fsf@gnu.org> References: <4BD592D9.1070801@redhat.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00883.txt.bz2 > Date: Mon, 26 Apr 2010 14:19:21 +0100 > From: Phil Muldoon > > This patch brings over GDB Parameter functionality from the Archer > project/repository. This functionality remains largely the same; I've > reintroduced some functionality back into py-cmd that was stripped > from the last FSF import, and fixed several bugs related to enum > parameters. It also introduces a new testsuite. Thanks. > 2010-04-26 Phil Muldoon > Tom Tromey > Thiago Jung Bauermann > > * gdb.texinfo (Parameters In Python): New Node. A few minor comments about this part. > +You can implement new @value{GDBN} parameters using Python. This should have a cross-reference to where GDB parameters are described in the manual (in the "Help" node). Alternatively, add here a short explanation what are they. (The name is unfortunate; I'd prefer "options" or "settings", but since we already use "parameters", so be it.) > +@var{name} is the name of the new parameter. If @var{name} consists > +of multiple words, then the initial words are looked for as prefix > +commands. An example here would help greatly. I would also suggest to drop the "commands" part, because we are not talking about commands here. > +@item PARAM_STRING > +The value is a string. When the user modifies the string, escapes are > +translated. It's not clear what escapes are meant here, and what translation does to them. I suggest an example or a few words of clarification. > +@findex PARAM_FILENAME > +@findex gdb.PARAM_FILENAME > +@item PARAM_FILENAME > +The value is a filename (a string). Is that just a string, or is it somehow different from a string? If the latter, let's tell what is the difference. Okay with these changes. Maybe we should consider mentioning this in NEWS. Thanks.