From: Eli Zaretskii <eliz@gnu.org>
To: gdb-patches@sourceware.org
Subject: Re: Quotes after --args
Date: Sat, 09 Jun 2012 14:58:00 -0000 [thread overview]
Message-ID: <838vfwttur.fsf@gnu.org> (raw)
In-Reply-To: <83bokstv04.fsf@gnu.org>
> Date: Sat, 09 Jun 2012 17:33:47 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: bhr2@gmx.de
>
> Any objections to the patch below, which fixes this problem? (I tried
> to minimize uglifying the original sources; if someone sees a better
> way, please tell.)
>
>
> 2012-06-09 Eli Zaretskii <eliz@gnu.org>
>
> * infcmd.c (construct_inferior_arguments) [__MINGW32__]: Quote
> special characters correctly for the Windows shells. See
> http://sourceware.org/ml/gdb/2012-06/msg00047.html for the bug
> report.
>
> --- infcmd.c~0 2012-02-23 10:18:38.000000000 +0200
> +++ infcmd.c 2012-06-09 17:20:57.750500000 +0300
> @@ -275,10 +275,18 @@ construct_inferior_arguments (int argc,
>
> if (STARTUP_WITH_SHELL)
> {
> +#ifdef __MINGW32__
> + /* This holds all the characters considered special to the
> + Windows shells. */
> + char *special = "\"!&*|[]{}<>?`~^=;, \t\n";
> + const char quote = '"';
> +#else
> /* This holds all the characters considered special to the
> typical Unix shells. We include `^' because the SunOS
> /bin/sh treats it as a synonym for `|'. */
> char *special = "\"!#$&*()\\|[]{}<>?'\"`~^; \t\n";
> + const char quote = '\'';
> +#endif
Btw, any idea why the Unix special characters mention the quote "
twice (see above)?
next prev parent reply other threads:[~2012-06-09 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1339164112.4081.ezmlm@sourceware.org>
[not found] ` <20120608142102.302310@gmx.net>
[not found] ` <833965voww.fsf@gnu.org>
2012-06-09 14:34 ` Eli Zaretskii
2012-06-09 14:58 ` Eli Zaretskii [this message]
2012-06-12 15:23 ` Tom Tromey
2012-06-12 16:37 ` Eli Zaretskii
2012-06-12 15:23 ` Tom Tromey
2012-06-12 16:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838vfwttur.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox