From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98743-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7762 invoked by alias); 22 Feb 2013 15:51:44 -0000
Received: (qmail 7749 invoked by uid 22791); 22 Feb 2013 15:51:42 -0000
X-SWARE-Spam-Status: No, hits=-4.5 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Feb 2013 15:51:34 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MIM00A00PCYQ100@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 22 Feb 2013 17:51:32 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MIM00A2SPDVK760@a-mtaout22.012.net.il>; Fri, 22 Feb 2013 17:51:31 +0200 (IST)
Date: Fri, 22 Feb 2013 15:51:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [rfc] remote, btrace: add branch tracing protocol to Qbtrace packet
In-reply-to: <1361546562-26827-1-git-send-email-markus.t.metzger@intel.com>
To: markus.t.metzger@intel.com
Cc: jan.kratochvil@redhat.com, gdb-patches@sourceware.org, markus.t.metzger@gmail.com, markus.t.metzger@intel.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <838v6gmjng.fsf@gnu.org>
References: <1361546562-26827-1-git-send-email-markus.t.metzger@intel.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00593.txt.bz2

> From: markus.t.metzger@intel.com
> Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com,        Markus Metzger <markus.t.metzger@intel.com>
> Date: Fri, 22 Feb 2013 16:22:42 +0100
> 
>  gdb/doc/gdb.texinfo    |   10 +++++++---
>  gdb/gdbserver/server.c |    6 +++---
>  gdb/remote.c           |    4 ++--
>  3 files changed, 12 insertions(+), 8 deletions(-)

The documentation part is OK, with one comment:

>> +@item Qbtrace:@var{method}
> +Enable branch tracing for the current thread using the @var{method}
> +branch trace recording method.

I would rephrase slightly:

 Enable branch tracing for the current thread using the specified
 @var{method} for branch trace recording.