From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-99857-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14904 invoked by alias); 25 Mar 2013 08:39:09 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 14821 invoked by uid 89); 25 Mar 2013 08:39:01 -0000
X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL,TW_SM autolearn=no version=3.3.1
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 25 Mar 2013 08:38:58 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MK700300JVUXN00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Mon, 25 Mar 2013 10:38:29 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MK70039TK04SW50@a-mtaout21.012.net.il>; Mon, 25 Mar 2013 10:38:28 +0200 (IST)
Date: Mon, 25 Mar 2013 12:43:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [MinGW-w64]Build gdb/ctf.c failed
In-reply-to: <515009B1.5030500@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: ktietz70@googlemail.com, asmwarrior@gmail.com, tromey@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <838v5b3mcx.fsf@gnu.org>
References: <83ip4s4ixc.fsf@gnu.org> <1363407692-18959-1-git-send-email-yao@codesourcery.com> <1363407692-18959-4-git-send-email-yao@codesourcery.com> <CADPb22RwSq0iv_gQu5PSGezQoUy0ve16M2hmL51HvM19v0M5Ow@mail.gmail.com> <51492077.30307@codesourcery.com> <83sj3qyogk.fsf@gnu.org> <87vc8m7z1d.fsf@fleche.redhat.com> <514FA117.9030604@gmail.com> <83hajz3oef.fsf@gnu.org> <CAEwic4Y020-LqwtNeYFXn3oQvk5fWBFm1T5ZoAmwqPSpD=PASg@mail.gmail.com> <515009B1.5030500@codesourcery.com>
X-SW-Source: 2013-03/txt/msg00922.txt.bz2

> Date: Mon, 25 Mar 2013 16:24:17 +0800
> From: Yao Qi <yao@codesourcery.com>
> CC: Eli Zaretskii <eliz@gnu.org>, asmwarrior <asmwarrior@gmail.com>,
> 	<tromey@redhat.com>, <gdb-patches@sourceware.org>
> 
> Right, 'mkdir' is declared io.h, which is included in unistd.h.  Looks
> like we should use "mkdir" instead of "_mkdir".  How about the patch
> below? It unbreaks the build of using mingw-w64 toolchain, while
> mingw32 toolchain doesn't complain about it.

I think you should "#undef mkdir" before redefining it, to be
absolutely safe here.

Other than that, I'm OK with this.