From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101399-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3379 invoked by alias); 11 May 2013 07:29:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 3358 invoked by uid 89); 11 May 2013 07:29:04 -0000
X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,SPF_SOFTFAIL autolearn=no version=3.3.1
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 11 May 2013 07:29:02 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MMM00A00HVV6L00@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Sat, 11 May 2013 10:28:53 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MMM00AK0I441J50@a-mtaout21.012.net.il>; Sat, 11 May 2013 10:28:53 +0300 (IDT)
Date: Sat, 11 May 2013 07:29:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] add -s option to make -break-insert support dprintf
In-reply-to: <CANFwon0NgSTcX+iuPsSPWU_t6O1UebETRrGvG7ghcAwC-MXTRA@mail.gmail.com>
To: Hui Zhu <teawater@gmail.com>
Cc: tromey@redhat.com, palves@redhat.com, hui_zhu@mentor.com, gdb-patches@sourceware.org, marc.khouzam@ericsson.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <838v3masbd.fsf@gnu.org>
References: <515451EA.1000200@mentor.com> <83y5d7wpvq.fsf@gnu.org> <CANFwon23qn_SVjcUWUZ2Z2Y5Euqg8efiwMvXkxTRtA9-2Ttk3Q@mail.gmail.com> <516454DA.9040109@redhat.com> <CANFwon1aDoyCYrsNeUpkmh6ARFJmT8B4JdFqYcc6GLdo=cgqig@mail.gmail.com> <87ppxzhfqy.fsf@fleche.redhat.com> <CANFwon2_yT4SOpK7=Rq=91nFcvk2Rn3_wAkCMmsfgP-6iynGig@mail.gmail.com> <516C2549.3060808@redhat.com> <CANFwon0WYLZEKWkfHzRgCB8MOPPoCsDvSaCk0SSYXPgonuE5zw@mail.gmail.com> <87vc7ithtj.fsf@fleche.redhat.com> <CANFwon0jwdrDULV+bPRX_5AWE2tgq=rSrA6eyZEujZqPfN+Huw@mail.gmail.com> <87wqrrll9m.fsf@fleche.redhat.com> <CANFwon3yyKxMVRO3wJ3=VTDLpege_NWByMA9-jk_g9_a5mXaoQ@mail.gmail.com> <87d2t2tt02.fsf@fleche.redhat.com> <CANFwon3meTbHqy-kfibR6XiJpkZdS3348am2wP6i9Dbz_sowLg@mail.gmail.com> <87ehdehnc9.fsf@fleche.redhat.com> <CANFwon0NgSTcX+iuPsSPWU_t6O1UebETRrGvG7ghcAwC-MXTRA@mail.gmail.com>
X-SW-Source: 2013-05/txt/msg00405.txt.bz2

> From: Hui Zhu <teawater@gmail.com>
> Date: Sat, 11 May 2013 10:37:56 +0800
> Cc: Pedro Alves <palves@redhat.com>, Eli Zaretskii <eliz@gnu.org>, Hui Zhu <hui_zhu@mentor.com>, 
> 	gdb-patches ml <gdb-patches@sourceware.org>, Marc Khouzam <marc.khouzam@ericsson.com>
> 
> --- a/NEWS
> +++ b/NEWS
> @@ -60,6 +60,8 @@ show debug nios2
>    ** The -trace-save MI command can optionally save trace buffer in Common
>       Trace Format now.
>  
> +  ** The new command -dprintf-insert sets a dynamic printf breakpoint.
> +
>  *** Changes in GDB 7.6

This part is OK.

> +If specified, @var{location}, can be one of:
> +
> +@itemize @bullet
> +@item function
> +@c @item +offset
> +@c @item -offset
> +@c @item linenum
> +@item filename:linenum
> +@item filename:function
> +@item *address
> +@end itemize

Each of "function", "filename", "linenum", and "address" above
should be in @var{}, because they do not stand for themselves.

> +If @var{location} cannot be parsed (for example if it
                                                  ^
A comma is missing.

> +refers to unknown files or functions), create a pending
> +breakpoint. Without this flag, @value{GDBN} will report
             ^^
Two spaces between sentences.

> +@item -i @var{ignore-count}
> +Initialize the @var{ignore-count}.

"Set the ignore count of the breakpoint (@pxref{Conditions, ignore
count}) to @var{ignore-count}."

> +Note: this format is open to change.

Why do we need this note in the manual?

> +The corresponding @value{GDBN} commands are @samp{dprintf}.
                                  ^^^^^^^^^^^^
"command is"

Thanks.