From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 723 invoked by alias); 22 May 2013 19:28:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 696 invoked by uid 89); 22 May 2013 19:28:59 -0000 X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.1 Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 22 May 2013 19:28:57 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MN700H00SI5FM00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Wed, 22 May 2013 22:28:39 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MN700HUESRO80B0@a-mtaout23.012.net.il>; Wed, 22 May 2013 22:28:39 +0300 (IDT) Date: Wed, 22 May 2013 19:28:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Revised display-linkage-name In-reply-to: <519D086A.50105@eagerm.com> To: Michael Eager Cc: gdb-patches@sourceware.org, tromey@redhat.com Reply-to: Eli Zaretskii Message-id: <838v36u84e.fsf@gnu.org> References: <519D086A.50105@eagerm.com> X-SW-Source: 2013-05/txt/msg00856.txt.bz2 > Date: Wed, 22 May 2013 11:03:22 -0700 > From: Michael Eager > CC: Tom Tromey > > Changes: > Add NEWS and docs. > Add linkage name to "info break" listing. > Add MI annotations. > Add command to set/show display length limit, remove define. > Add test case. Thanks. > +set|show display-linkage-name-len > + > + Set the maximum number of characters to display in the linkage name, > + if display-linkage-name is on. The default is 20. Do we really need this? Why not display the whole name always? > +@kindex set display-linkage-name @code{on}|@code{off} Please remove the on|off part from the index entry. Just the command is enough. > +@cindex list linker symbol names Is "linker symbol name" how users would expect this to be called? I wouldn't. Index entries should use phrases that readers might have in mind when they are looking for the stuff described in this section. I think the correct terminology is "linkage name". > +The default is @code{off}, which means that @value{GDBN} will only > +display the function name used in the source. When @code{on}, @value{GDBN} > +will also display the symbol name used by the linker within brackets if it is > +different from the name in the source. This can be useful with compilers > +which may prepend characters to a source name, for example, an underscore. > + > +This is different from "set print asm-demangle on" which only displays > +the linkage name for C++ symbols and does not display the source name. Isn't it confusing to have 2 subtly different settings that actually achieve almost the same? How about a single setting, perhaps a tristate, instead of 2 separate booleans? > +@kindex set display-linkage-name-len > +@kindex show display-linkage-name-len > +@cindex list linker symbol names ^^^^^^^^^^^^^^^^^^^^^^^^ Copy/paste error? You already have an identical index entry a few lines above. > +@item set display-linkage-name-len @var{len} > +@itemx show display-linkage-name-len @var{len} > +Set the maximum number of characters of linkage name to display. The > +@code{show} command displays the current setting. The default is @code{20}. I think we don't need this setting. After all, we show source-level function names in their full glory, right?