From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29653 invoked by alias); 6 Sep 2013 13:25:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29637 invoked by uid 89); 6 Sep 2013 13:25:39 -0000 Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2013 13:25:39 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED autolearn=ham version=3.3.2 X-HELO: mtaout22.012.net.il Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MSP00C00GSMP100@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Fri, 06 Sep 2013 16:25:36 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MSP00CF0HAON960@a-mtaout22.012.net.il>; Fri, 06 Sep 2013 16:25:36 +0300 (IDT) Date: Fri, 06 Sep 2013 13:25:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH] Remove use of deprecated_init_ui_hook from quit_confirm. In-reply-to: <5229CAA4.4090709@broadcom.com> To: Andrew Burgess Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <838uzam69j.fsf@gnu.org> References: <5229CAA4.4090709@broadcom.com> X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00228.txt.bz2 > Date: Fri, 6 Sep 2013 13:29:24 +0100 > From: "Andrew Burgess" > > There are only two places that deprecated_init_ui_hook is set > (to !NULL) that I can find: > > 1. In gdbtk, deprecated_init_ui_hook is used to grab a copy of > argv0, but is then immediately set back to NULL, and > > 2. In windows-nat.c, deprecated_init_ui_hook is used to solve > an order of initialisation problem when creating a command > alias, in this case deprecated_init_ui_hook is left set. > > In top.c:quit_confirm we check deprecated_init_ui_hook to detect if > there's a GUI running. For (1) above this will not kick in, but > for (2) it does.... however... I don't see why this is a good thing, > as I understand it the windows-nat.c code is not a GUI frontend for > gdb, but is just "running-gdb-on-windows-hosts". I find it hard to > believe that the shorter, less informative, quit message is really > desired... but maybe I've missed something. > > The following patch removes the use of deprecated_init_ui_hook > from quit_confirm, the only change I expect from this is that the > quit message on windows hosts will fall into line with other hosts. What situation would trigger the different quit message on Windows? In GDB 7.6.1 built as MinGW native debugger for Windows, I only see the "normal" quit message, viz.: (gdb) q A debugging session is active. Inferior 1 [process 628] will be killed. Quit anyway? (y or n) y So it looks like the allegedly Windows-specific quit message is never used, although deprecated_init_ui_hook is non-NULL. What am I missing? > OK to apply? I'd suggest to wait until we fully understand the situation with this hook. Thanks.