From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119394 invoked by alias); 20 May 2015 15:49:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119356 invoked by uid 89); 20 May 2015 15:49:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout28.012.net.il Received: from mtaout28.012.net.il (HELO mtaout28.012.net.il) (80.179.55.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 May 2015 15:49:53 +0000 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NON00E00NQ8I400@mtaout28.012.net.il> for gdb-patches@sourceware.org; Wed, 20 May 2015 18:48:54 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NON007IRNXIGM70@mtaout28.012.net.il>; Wed, 20 May 2015 18:48:54 +0300 (IDT) Date: Wed, 20 May 2015 15:49:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v5] Explicit locations: documentation updates In-reply-to: <20150519221511.808.10790.stgit@valrhona.uglyboxes.com> To: Keith Seitz Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <838ucj6yg7.fsf@gnu.org> References: <20150519221511.808.10790.stgit@valrhona.uglyboxes.com> X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00518.txt.bz2 > From: Keith Seitz > Date: Tue, 19 May 2015 15:16:43 -0700 > > This patch adds documentation for explicit locations to both the > User Manual and gdb's online help system. > > gdb/ChangeLog: > > * NEWS: Mention explicit locations. > * breakpoint.c [LOCATION_HELP_STRING]: New macro. > [BREAK_ARGS_HELP]: Use LOCATION_HELP_STRING. > (_initialize_breakpoint): Update documentation for > "clear", "break", "trace", "strace", "ftrace", and "dprintf". > > gdb/doc/ChangeLog: > > * gdb.texinfo (Thread-Specific Breakpoints, Printing Source Lines): > Use "location(s)"instead of "linespec(s)". > (Specifying a Location): Rewrite. > Add subsections describing linespec, address, and explicit locations. > Add node/menu for each subsection. > (Source and Machine Code, C Preprocessor Macros) > (Create and Delete Trace points) > (Extensions for Ada Tasks): Use "location(s)" instead of "linespec(s)". > (Continuing at a Different Address): Remove "linespec" examples. > Add reference to "Specify a Location" > (The -break-insert Command): Rewrite. Add anchor. > Add reference to appropriate manual section discussing locations. > (The -dprintf-insert Command): Refer to -break-insert for > specification of 'location'. > > This patch is originally #9/9. > > Differences from the last version: > > 1. Changed anchors to nodes for new subections. > 2. Added new subsection menu to parent node, Specify Location. > 3. Added @code as requested/necessary. > 4. Updated ChangeLog > > [Eli, I know you pre-approved with fixes, but I'd appreciate one more > look at this to double-check one more time.] LGTM, with one comment: > +@node Linespec Locations > +@subsection Linespec Locations Please add a @cindex entry here that's identical to the subsection name, just without capitalization, like you did for the other 2 subsections you wrote. Thanks.