From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-124648-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 73714 invoked by alias); 24 Jul 2015 19:17:39 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 73701 invoked by uid 89); 24 Jul 2015 19:17:38 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout21.012.net.il
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Jul 2015 19:17:37 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NS000C00AM6D100@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Fri, 24 Jul 2015 22:17:34 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NS000CF5AXAD410@a-mtaout21.012.net.il>; Fri, 24 Jul 2015 22:17:34 +0300 (IDT)
Date: Fri, 24 Jul 2015 19:17:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Make sure GDB uses a valid shell when starting the inferior and to perform the "shell" command
In-reply-to: <87k2tp5q3g.fsf@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <838ua52wmp.fsf@gnu.org>
References: <1437761993-18758-1-git-send-email-sergiodj@redhat.com> <55B2850D.6030306@ericsson.com> <87k2tp5q3g.fsf@redhat.com>
X-IsSubscribed: yes
X-SW-Source: 2015-07/txt/msg00719.txt.bz2

> From: Sergio Durigan Junior <sergiodj@redhat.com>
> Cc: GDB Patches <gdb-patches@sourceware.org>
> Date: Fri, 24 Jul 2015 15:10:27 -0400
> 
> > Note that on my Ubuntu 14.04:
> >
> > $ which nologin
> > /usr/sbin/nologin
> 
> /sbin/nologin is probably a symlink to this file, isn't it?  But yeah,
> the check could include /usr/sbin/nologin as well.
> 
> > I think that /bin/false is also commonly specified as the default shell
> > for system users (at least according to my /etc/passwd).
> 
> Indeed.  I will include /bin/false as well.

Since the number of valid shells is much smaller than the number of
non-shell programs, isn't it better to have a database of known shells
than to have a database of non-shells people could be expected to set
SHELL to?