From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-126481-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 42629 invoked by alias); 5 Oct 2015 17:00:15 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 42616 invoked by uid 89); 5 Oct 2015 17:00:15 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout21.012.net.il
Received: from mtaout21.012.net.il (HELO mtaout21.012.net.il) (80.179.55.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Oct 2015 17:00:13 +0000
Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NVR00L00AUK5700@a-mtaout21.012.net.il> for gdb-patches@sourceware.org; Mon, 05 Oct 2015 20:00:11 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NVR00L1XB8A3A40@a-mtaout21.012.net.il>; Mon, 05 Oct 2015 20:00:11 +0300 (IDT)
Date: Mon, 05 Oct 2015 17:00:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v2 7/7] Support software breakpoints for ARM linux in GDBServer.
In-reply-to: <1444063455-31558-8-git-send-email-antoine.tremblay@ericsson.com>
To: Antoine Tremblay <antoine.tremblay@ericsson.com>
Cc: gdb-patches@sourceware.org, antoine.tremblay@ericsson.com
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <838u7hz1wl.fsf@gnu.org>
References: <1444063455-31558-1-git-send-email-antoine.tremblay@ericsson.com> <1444063455-31558-8-git-send-email-antoine.tremblay@ericsson.com>
X-IsSubscribed: yes
X-SW-Source: 2015-10/txt/msg00045.txt.bz2

> From: Antoine Tremblay <antoine.tremblay@ericsson.com>
> CC: Antoine Tremblay <antoine.tremblay@ericsson.com>
> Date: Mon, 5 Oct 2015 12:44:15 -0400
> 
> This patch implements the breakpoint_from_kind operation introduced
> in a previous patch.
> 
> The proper breakpoint can then be returned to be inserted in memory.
> 
> It enables software breakpoints via GDB's Z0 packets on ARM.
> 
> No regressions, tested on ubuntu 14.04 ARMv7 and x86.
> With gdbserver-{native,extended} / { -marm -mthumb }
> 
> gdb/ChangeLog:
> 	* NEWS: Add news for software breakpoints.
> 
> gdb/gdbserver/ChangeLog:
> 	* linux-arm-low.c (arm_breakpoint_from_kind): New function.
> 	(arm_supports_z_point_type): Add software breakpoint support.
> 	(struct linux_target_ops) <breakpoint_from_kind>: Initialize field.

OK for the NEWS part.