From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32321 invoked by alias); 30 Jun 2016 18:57:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32310 invoked by uid 89); 30 Jun 2016 18:57:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:607, HX-HELO:eggs.gnu.org, Hx-spam-relays-external:208.118.235.92, H*RU:208.118.235.92 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 30 Jun 2016 18:57:31 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIh9S-0006Lh-M7 for gdb-patches@sourceware.org; Thu, 30 Jun 2016 14:57:29 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIh9S-0006LY-JF; Thu, 30 Jun 2016 14:57:26 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4849 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bIh9Q-0002vM-BU; Thu, 30 Jun 2016 14:57:25 -0400 Date: Thu, 30 Jun 2016 18:57:00 -0000 Message-Id: <838txmv72f.fsf@gnu.org> From: Eli Zaretskii To: LRN CC: gdb-patches@sourceware.org In-reply-to: <2af222f0-f7d9-f0b4-b1cf-8b2d78f777fd@gmail.com> (message from LRN on Thu, 30 Jun 2016 21:36:12 +0300) Subject: Re: [Bug win32/14529] Make gdb capable of JIT-debugging on W32 Reply-to: Eli Zaretskii References: <503E575D.1000608@gmail.com> <506A1DB5.60901@gmail.com> <20121002124819.GB3028@adacore.com> <506AE4C6.9010304@gmail.com> <4be546e0-7811-6f51-e5a4-d441e8a9d16a@gmail.com> <83oa6ivgve.fsf@gnu.org> <83inwqve6d.fsf@gnu.org> <6349c1ab-c4a3-f6d5-f61e-6f1f7e2dfcaf@gmail.com> <83eg7evajb.fsf@gnu.org> <2af222f0-f7d9-f0b4-b1cf-8b2d78f777fd@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00562.txt.bz2 > From: LRN > Date: Thu, 30 Jun 2016 21:36:12 +0300 > > >> I did. What did i do wrong? Had a single space (instead of two spaces) > >> after the name? Used "Fix PR gdb/14529" at the end instead of "PR > >> gdb/14529" at the beginning? No function name in parentheses (should it > >> have been signal_event_command?)? > > > > The latter. > > > > Fixed patches attached. Thanks. One last nit is that the ChangeLog entry for gdb.texinfo should also state a "function name", which is the node name where you made the changes.