From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45639 invoked by alias); 29 Aug 2018 19:29:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45630 invoked by uid 89); 29 Aug 2018 19:29:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 19:29:01 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fv699-0002U5-Qp for gdb-patches@sourceware.org; Wed, 29 Aug 2018 15:28:59 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fv699-0002Tx-Mr; Wed, 29 Aug 2018 15:28:55 -0400 Received: from [176.228.60.248] (port=2509 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fv698-0008KB-3s; Wed, 29 Aug 2018 15:28:55 -0400 Date: Wed, 29 Aug 2018 19:29:00 -0000 Message-Id: <838t4p2crb.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: tom@tromey.com, palves@redhat.com, gdb-patches@sourceware.org In-reply-to: <87a7p53rm4.fsf@tromey.com> (message from Tom Tromey on Wed, 29 Aug 2018 13:22:27 -0600) Subject: Re: [PATCH] Fix windows-nat.c for -Wnarrowing References: <20180829174253.18507-1-tom@tromey.com> <88f0fbca-f10a-9139-f96a-7934e10a937c@redhat.com> <87in3t3sqb.fsf@tromey.com> <87efeh3snr.fsf@tromey.com> <83a7p52dbh.fsf@gnu.org> <87a7p53rm4.fsf@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00772.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey , palves@redhat.com, gdb-patches@sourceware.org > Date: Wed, 29 Aug 2018 13:22:27 -0600 > > >>>>> "Eli" == Eli Zaretskii writes: > > Eli> Why did you need to make .them be DWORD? I think it should be a > Eli> 'long', and then you can use -1L without any trouble. > > Thanks for the suggestion. I tried this just now but long doesn't work > without additional casts: > > ../../binutils-gdb/gdb/windows-nat.c:304:1: error: narrowing conversion of '3221225477' from 'DWORD {aka long unsigned int}' to 'long int' inside { } [-Wnarrowing] > }; > ^ I don't understand: EXCEPTION_ACCESS_VIOLATION is defined like this: #define STATUS_ACCESS_VIOLATION 0xC0000005 #define EXCEPTION_ACCESS_VIOLATION STATUS_ACCESS_VIOLATION And you've removed DWORD from the definition of xlate. So where does DWORD come from?