From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40380 invoked by alias); 19 Dec 2019 03:35:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40371 invoked by uid 89); 19 Dec 2019 03:35:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=wish X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 03:35:31 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ihmb3-0007PF-Ry; Wed, 18 Dec 2019 22:35:29 -0500 Received: from [176.228.60.248] (port=2430 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ihmb2-0000OG-PZ; Wed, 18 Dec 2019 22:35:29 -0500 Date: Thu, 19 Dec 2019 03:35:00 -0000 Message-Id: <838sn92dja.fsf@gnu.org> From: Eli Zaretskii To: Christian Biesinger CC: gdb-patches@sourceware.org In-reply-to: <20191219000103.36667-4-cbiesinger@google.com> (gdb-patches@sourceware.org) Subject: Re: [PATCH 2/3] Cast the log10 argument to double to disambiguate it References: <20191219000103.36667-1-cbiesinger@google.com> <20191219000103.36667-4-cbiesinger@google.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00808.txt.bz2 > Date: Wed, 18 Dec 2019 18:01:02 -0600 > From: "Christian Biesinger via gdb-patches" > Cc: Christian Biesinger > > On Solaris 11 with gcc 5.5.0 (gcc211 on the compile farm), math.h has a > using std::log10; directive. This is unfortunate because std::log10 has > overloads for float/double/long double. To disambiguate this call, > cast the argument to double to fix the build. We may wish to have a comment in the code referring to the original problem, including perhaps the OS and the compiler versions? Otherwise the need for this cast is not immediately obvious, IMO. Thanks.