Re: [PATCH v3] Handle Windows drives in auto-load script paths

[Eli Zaretskii <eliz@gnu.org>]

> From: Hannes Domani <ssbssa@yahoo.de>
> Date: Wed,  8 Jul 2020 19:19:57 +0200
> 
> Fixes this testsuite fail on Windows:
> FAIL: gdb.base/auto-load.exp: print $script_loaded
> 
> Converts the debugfile path from c:/dir/file to /c/dir/file, so it can be
> appended to the auto-load path.
> 
> gdb/ChangeLog:
> 
> 2020-07-08  Hannes Domani  <ssbssa@yahoo.de>
> 
> 	* auto-load.c (auto_load_objfile_script_1): Convert drive part
> 	of debugfile path on Windows.
> 
> gdb/doc/ChangeLog:
> 
> 2020-07-08  Hannes Domani  <ssbssa@yahoo.de>
> 
> 	* gdb.texinfo: Document Windows drive conversion of
> 	'set auto-load scripts-directory'.

This LGTM, as I said earlier.

One minor aesthetic nit, though:

> +	  debugfile_holder = STRIP_DRIVE_SPEC (debugfile);
> +	  filename = std::string("/") + debugfile[0] + debugfile_holder;

Perhaps it is slightly better to use "\\" here instead of "/", since
on both sides of that "/D" thing all other separators are backslashes,
so this forward slash looks like the odd one out.

Thanks.