From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KDPGJF3DBWByIgAAWB0awg (envelope-from ) for ; Mon, 18 Jan 2021 12:20:29 -0500 Received: by simark.ca (Postfix, from userid 112) id 91D481EF80; Mon, 18 Jan 2021 12:20:29 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BCBCE1E940 for ; Mon, 18 Jan 2021 12:20:28 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 78919384B822; Mon, 18 Jan 2021 17:20:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 78919384B822 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610990428; bh=s3YTJdKRwJxZhSpVu2FIZkpuXq/9SUDnMigjGz7TEyg=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=bwc1gV0ITQH6ulauepTWY0lulhbyLCXt/DqYs8dAXIYeHuikTIUER/C6jElb1Fdxi VtnCM7qBjDq9TwcI5qL2eN/m0WA4lduasZEImyUAd7Y3O0Kgsx0HDahUVGo4NGrmCW irHT34sZzpYqzNUzaX1u8Kv0yeAA7mYamx3mZ0mY= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 3B0BC384B822 for ; Mon, 18 Jan 2021 17:20:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3B0BC384B822 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60337) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1YCX-000371-FQ; Mon, 18 Jan 2021 12:20:25 -0500 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1614 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l1YC1-00087E-Cz; Mon, 18 Jan 2021 12:20:07 -0500 Date: Mon, 18 Jan 2021 19:19:57 +0200 Message-Id: <838s8q88n6.fsf@gnu.org> To: Andrew Burgess In-Reply-To: <20210115164811.GK265215@embecosm.com> (message from Andrew Burgess on Fri, 15 Jan 2021 16:48:11 +0000) Subject: Re: [PATCH 2/4] Return true in TuiWindow.is_valid only if TUI is enabled References: <20201229170227.821-1-ssbssa@yahoo.de> <20201229170227.821-2-ssbssa@yahoo.de> <20210115164811.GK265215@embecosm.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: tom@tromey.com, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > Date: Fri, 15 Jan 2021 16:48:11 +0000 > From: Andrew Burgess > Cc: Tom Tromey , gdb-patches@sourceware.org > > gdb/ChangeLog: > > * python/py-tui.c (struct gdbpy_tui_window)> : New > member function. > (class tui_py_window) : Likewise. > (REQUIRE_WINDOW): Call is_valid member function. > (gdbpy_tui_is_valid): Likewise. > * tui/tui-data.h (struct tui_win_info) : Check > tui_active too. > * tui/tui-layout.c (tui_apply_current_layout): Add an assert. > * tui/tui.c (tui_enable): Move setting of tui_active earlier in > the function. > > gdb/doc/ChangeLog: > > * python.texinfo (TUI Windows In Python): Extend description of > TuiWindow.is_valid. > > gdb/testsuite/ChangeLog: > > * gdb.python/tui-window-disabled.c: New file. > * gdb.python/tui-window-disabled.exp: New file. > * gdb.python/tui-window-disabled.py: New file. OK for the documentation part, thanks.