From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CBFtAXsOlGCNJgAAWB0awg (envelope-from ) for ; Thu, 06 May 2021 11:42:51 -0400 Received: by simark.ca (Postfix, from userid 112) id 03D221F11C; Thu, 6 May 2021 11:42:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 752ED1E01F for ; Thu, 6 May 2021 11:42:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0FDE3388C014; Thu, 6 May 2021 15:42:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0FDE3388C014 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620315770; bh=LEvW661s5nOKZDkgifzCxUja+P+8gMqdFqRFwWRhbTE=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=UddB+hZ2eDimDoHAaXS6V9shzd05VQIfAKyW7WZVkZkptCRUtGf3Iltr52lYtDBrJ YoPNE99GyHH7HFXWfZMpIQzdbpOqVxF3ZJOMm+oYbeif9rLEvlv/0jGwu40P6eD/Ha ud03hFoFNTYCNPGEeJkb0YMc6LxdXEHafq/+Wdr4= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 6C99E388C014 for ; Thu, 6 May 2021 15:42:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6C99E388C014 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45648) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leg9H-00024l-IR; Thu, 06 May 2021 11:42:47 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3244 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1leg9C-0000Dd-E7; Thu, 06 May 2021 11:42:43 -0400 Date: Thu, 06 May 2021 18:42:34 +0300 Message-Id: <838s4reumt.fsf@gnu.org> To: Tom de Vries In-Reply-To: <02160b9a-c3a0-7634-791f-28a40b1703a1@suse.de> (message from Tom de Vries on Thu, 6 May 2021 17:24:10 +0200) Subject: Re: [PATCH][gdb/symtab] Fix infinite recursion in dwarf2_cu::get_builder() References: <20210506120247.GA1559@delia.home> <83fsyzevty.fsf@gnu.org> <02160b9a-c3a0-7634-791f-28a40b1703a1@suse.de> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: tom@tromey.com, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > Cc: gdb-patches@sourceware.org, tom@tromey.com > From: Tom de Vries > Date: Thu, 6 May 2021 17:24:10 +0200 > > +when using @sc{dwarf 2}. Versions of @value{NGCC} before 4.1 > +do not emit two required attributes (@samp{DW_AT_call_file} and > +@samp{DW_AT_call_line}); @value{GDBN} does not display inlined > +function calls with earlier versions of @value{NGCC}. It instead > +displays the arguments and local variables of inlined functions as > +local variables in the caller. > ... > > I'm undoing that change, and updating the documentation accordingly. Ah, okay. Then it's fine, but be sure to include a suitable change in gdb/doc/ChangeLog as well.