From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lIzZFXXgXmJGOgAAWB0awg (envelope-from ) for ; Tue, 19 Apr 2022 12:16:53 -0400 Received: by simark.ca (Postfix, from userid 112) id 4647B1F377; Tue, 19 Apr 2022 12:16:53 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="hM95DjKs"; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C462A1ED17 for ; Tue, 19 Apr 2022 12:16:52 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 35FB43858C83 for ; Tue, 19 Apr 2022 16:16:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 35FB43858C83 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1650385012; bh=2HcVtfI5cKftNN3K4nqH37DK4YoB2bHMGeCvG4C3eco=; h=Date:To:In-Reply-To:Subject:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hM95DjKsEaGlMicrhH+vekIyd56CG6ZqYjQhyQ6n9/XwHlwYgw57XvMAfBrAAv9ZK OceitIyK44+6b5KOw5mtSxi6FIa0wCr+9BkOB6jMlcZJYBiXUuXc95TDNE1IqB6BYL 1Qs60SdETha1n3CFdYxgLZQ909V/gxg7xyLhKUOA= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 59F993858C83 for ; Tue, 19 Apr 2022 16:16:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 59F993858C83 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43408) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngqWm-0004tN-JA; Tue, 19 Apr 2022 12:16:32 -0400 Received: from [87.69.77.57] (port=3888 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngqWl-0007Wp-DZ; Tue, 19 Apr 2022 12:16:32 -0400 Date: Tue, 19 Apr 2022 19:16:22 +0300 Message-Id: <838rs1ujzd.fsf@gnu.org> To: Andrew Burgess In-Reply-To: <874k2prr1c.fsf@redhat.com> (message from Andrew Burgess on Tue, 19 Apr 2022 17:12:15 +0100) Subject: Re: GDB 12.0.90 available for testing References: <87pmm096dc.fsf@redhat.com> <83zgl44w1m.fsf@gnu.org> <1379565857.1750775.1648990951974@mail.yahoo.com> <1113857996.1779276.1648999598328@mail.yahoo.com> <83czhyfa8i.fsf@gnu.org> <83wng1b161.fsf@gnu.org> <83tuaz6e3x.fsf@gnu.org> <874k2prr1c.fsf@redhat.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Cc: pedro@palves.net, brobecker@adacore.com, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > From: Andrew Burgess > Cc: Eli Zaretskii , Joel Brobecker , pedro@palves.net > Date: Tue, 19 Apr 2022 17:12:15 +0100 > > Sorry for the slow reply, I've been off for the last week, so I'm only > just catching up with my GDB emails. > > How does the patch below look? This moves the setbuf call into a new > function, and includes the comment from gdb_readline_no_editing_callback. Thanks. However, the patch that I tested only used the ISATTY test in ui::ui, not in read_command. Not sure if that matters.