From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NAxlF8QqyWNYPhoAWB0awg (envelope-from ) for ; Thu, 19 Jan 2023 06:34:28 -0500 Received: by simark.ca (Postfix, from userid 112) id 53C1B1E128; Thu, 19 Jan 2023 06:34:28 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=BpgSy5sZ; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0C0841E110 for ; Thu, 19 Jan 2023 06:34:28 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8231B3858439 for ; Thu, 19 Jan 2023 11:34:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8231B3858439 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674128067; bh=uAojW4AMlWrkdaeLpDePMLpWm5kjMEVBZcmJahJJC+Y=; h=Date:To:Cc:In-Reply-To:Subject:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=BpgSy5sZFuDK4/3okXw5rZJiwqbRTS9Ye9DCHp2G9HRuMb5KrjTD2vdbaWvo2BhhB OdjloDTbNKV4zPYmzCPZ9SoSiPvBfviqv5SMuCMcNeSVS9IeJBj0sICy6QAOA5Grp7 gZ2y8KH8czQf//NGKamaiigoFTZrS1U9Gb9EOgDo= Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id C17B83858C53 for ; Thu, 19 Jan 2023 11:34:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C17B83858C53 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pITBG-0004j2-NG; Thu, 19 Jan 2023 06:34:07 -0500 Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pITBF-0005c9-DV; Thu, 19 Jan 2023 06:34:05 -0500 Date: Thu, 19 Jan 2023 13:34:03 +0200 Message-Id: <838rhypxlg.fsf@gnu.org> To: "Aktemur, Tankut Baris" Cc: aburgess@redhat.com, gdb-patches@sourceware.org In-Reply-To: (tankut.baris.aktemur@intel.com) Subject: Re: [PATCHv2 03/13] gdb: include breakpoint number in testing condition error message References: <478a1e660361f1290c2dd8e9ad999d59d0ad3dcb.1674058359.git.aburgess@redhat.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Zaretskii via Gdb-patches Reply-To: Eli Zaretskii Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > From: "Aktemur, Tankut Baris" > Date: Thu, 19 Jan 2023 10:54:16 +0000 > > On Wednesday, January 18, 2023 5:18 PM, Andrew Burgess wrote: > ... > > So, in this commit, in preparation for the later commits, I propose to > > change the 'Error in testing breakpoint condition:' line to this: > > > > Error in testing condition for breakpoint NUMBER: > > Here, because we're now referring to a particular breakpoint, > I believe the spelling should be "condition for Breakpoint NUMBER:", > with uppercase 'B'. Maybe Eli can comment on this, too. No, capitalized "Breakpoint" would read wrong English-wise in that case.