From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46962 invoked by alias); 8 Nov 2016 19:31:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46947 invoked by uid 89); 8 Nov 2016 19:31:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Allocate X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Nov 2016 19:31:06 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6BA4861BA2; Tue, 8 Nov 2016 19:31:05 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA8JV4AT028551; Tue, 8 Nov 2016 14:31:04 -0500 Subject: Re: [PATCH 3/4] tui-winsource: Allocate for actual lines only To: Andreas Arnez , gdb-patches@sourceware.org References: <1478631454-9447-1-git-send-email-arnez@linux.vnet.ibm.com> <1478631454-9447-4-git-send-email-arnez@linux.vnet.ibm.com> From: Pedro Alves Message-ID: <838aec4b-da40-35af-2088-19545038d1c1@redhat.com> Date: Tue, 08 Nov 2016 19:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1478631454-9447-4-git-send-email-arnez@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00185.txt.bz2 On 11/08/2016 06:56 PM, Andreas Arnez wrote: > The logic for allocating a TUI source window's content buffer allocates > two more lines than needed, because it does not reduce the window height > by the highlight box's overhead. However, it does reduce the line width > accordingly. This patch makes the height and width calculation > consistent and improves the comment. > > gdb/ChangeLog: > > * tui/tui-winsource.c (tui_alloc_source_buffer): Subtract > highlight box's overhead when calculating the content height. OK. Thanks, Pedro Alves