From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13873 invoked by alias); 24 Apr 2009 10:20:13 -0000 Received: (qmail 13865 invoked by uid 22791); 24 Apr 2009 10:20:13 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout6.012.net.il (HELO mtaout6.012.net.il) (84.95.2.16) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Apr 2009 10:20:05 +0000 Received: from conversion-daemon.i-mtaout6.012.net.il by i-mtaout6.012.net.il (HyperSendmail v2007.08) id <0KIL00G00OITWS00@i-mtaout6.012.net.il> for gdb-patches@sourceware.org; Fri, 24 Apr 2009 13:19:49 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.127.175.232]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KIL00D5IOP1H0D0@i-mtaout6.012.net.il>; Fri, 24 Apr 2009 13:19:49 +0300 (IDT) Date: Fri, 24 Apr 2009 10:20:00 -0000 From: Eli Zaretskii Subject: Re: [RFA/commit] Handle EOF on terminals opened with ENONBLOCK... In-reply-to: <20090423191446.GB7512@adacore.com> To: Joel Brobecker Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <837i1agxq2.fsf@gnu.org> References: <20090423191446.GB7512@adacore.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00689.txt.bz2 > Date: Thu, 23 Apr 2009 12:14:46 -0700 > From: Joel Brobecker > > 2009-04-23 Joel Brobecker > > * utils.c: Add include of gdb_usleep.h. > (defaulted_query): Detect false EOF conditions that happen > on terminals opened with the O_NONBLOCK flag when there is > nothing to read. > > We've tested this patch on all the hosts that AdaCore supports. > This includes GNU/Linux, Solaris, AIX, Tru64, MinGW... > Would it be OK to commit? Fine with me, but I'd prefer that you tell more details in the comment, and/or maybe add a link to this thread of discussion. As written, the comment doesn't give any clues, not even to what OS was that discovered on. Thanks.